From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v2 10/10] efi: efi-stub: notify on DTB absence Date: Tue, 4 Nov 2014 17:42:21 +0000 Message-ID: <20141104174221.GD3592@console-pimps.org> References: <1414513123-20400-1-git-send-email-ard.biesheuvel@linaro.org> <1414513123-20400-11-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1414513123-20400-11-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, yi.li-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: linux-efi@vger.kernel.org On Tue, 28 Oct, at 05:18:43PM, Ard Biesheuvel wrote: > From: Mark Rutland > > In the absence of a DTB configuration table, the EFI stub will happily > continue attempting to boot a kernel, despite the fact that this kernel > may not function without a description of the hardware. In this case, as > with a typo'd "dtb=" option (e.g. "dbt=") or many other possible > failures, the only output seen by the user will be the rather terse > output from the EFI stub: > > EFI stub: Booting Linux Kernel... > > To aid those attempting to debug such failures, this patch adds a notice > when no DTB is found, making the output more helpful: > > EFI stub: Booting Linux Kernel... > EFI stub: Generating empty DTB > > Additionally, a positive acknowledgement is added when a user-specified > DTB is in use: > > EFI stub: Booting Linux Kernel... > EFI stub: Using DTB from command line > > Similarly, a positive acknowledgement is added when a DTB from a > configuration table is in use: > > EFI stub: Booting Linux Kernel... > EFI stub: Using DTB from configuration table > > Signed-off-by: Mark Rutland > Acked-by: Leif Lindholm > Acked-by: Ard Biesheuvel > Cc: Mark Salter > Cc: Matt Fleming > Acked-by: Roy Franz > Signed-off-by: Ard Biesheuvel > --- > drivers/firmware/efi/libstub/arm-stub.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Can't really argue with this. Acked-by: Matt Fleming -- Matt Fleming, Intel Open Source Technology Center