From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 2/2] efi: Capsule update support Date: Fri, 7 Nov 2014 15:12:09 +0000 Message-ID: <20141107151209.GL3592@console-pimps.org> References: <20141013095310.GZ14343@console-pimps.org> <20141016161507.GJ14343@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sam Protsenko Cc: Matt Fleming , Leif Lindholm , hock.leong.kweh@intel.com, "linux-efi@vger.kernel.org" , linux-kernel@vger.kernel.org List-Id: linux-efi@vger.kernel.org On Tue, 04 Nov, at 03:56:22PM, Sam Protsenko wrote: > Matt, > > I've tested your patch with zero image size (no image passed, only headers) > and it crashes because there is no check for image size there. > This case (zero image size) seems to be legit according to specification > and also can be useful in real life. So I developed a little fix for your patch: [...] > I'm planning to use your API for our UpdateCapsule test module so > it would be really helpful if you can include this fix to your patch. Sure, I'll include that snippet and post fixed up code next week. Thanks Sam. -- Matt Fleming, Intel Open Source Technology Center