From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leif Lindholm Subject: Re: [Linaro-uefi] [PATCH] firmware: efi: remove unneeded guid unparse Date: Tue, 20 Jan 2015 16:39:08 +0000 Message-ID: <20150120163908.GS3827@bivouac.eciton.net> References: <1421770352-5059-1-git-send-email-ivan.khoronzhuk@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: Ivan Khoronzhuk , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Matt Fleming , Linaro Kernel Mailman List , Linaro UEFI Mailman List List-Id: linux-efi@vger.kernel.org On Tue, Jan 20, 2015 at 04:20:10PM +0000, Ard Biesheuvel wrote: > On 20 January 2015 at 16:12, Ivan Khoronzhuk wrote: > > There is no reason to translate guid number to string here. > > So remove it in order to not do unneeded work. > > > > Signed-off-by: Ivan Khoronzhuk > > --- > > drivers/firmware/efi/efi.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > > index 9035c1b..f6be017 100644 > > --- a/drivers/firmware/efi/efi.c > > +++ b/drivers/firmware/efi/efi.c > > @@ -272,15 +272,10 @@ static __init int match_config_table(efi_guid_t *guid, > > unsigned long table, > > efi_config_table_type_t *table_types) > > { > > - u8 str[EFI_VARIABLE_GUID_LEN + 1]; > > int i; > > > > if (table_types) { > > - efi_guid_unparse(guid, str); > > - > > for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) { > > - efi_guid_unparse(&table_types[i].guid, str); > > - > > if (!efi_guidcmp(*guid, table_types[i].guid)) { > > *(table_types[i].ptr) = table; > > pr_cont(" %s=0x%lx ", Doh! Left the unparses in after I removed the debug printouts :| Thanks for spotting. Acked-by: Leif Lindholm > Acked-by: Ard Biesheuvel / Leif