* Re: [Linaro-uefi] [PATCH] firmware: efi: remove unneeded guid unparse [not found] ` <1421770352-5059-1-git-send-email-ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> @ 2015-01-20 16:20 ` Ard Biesheuvel [not found] ` <CAKv+Gu87L6xhEbTiWSdcY6RCk3yc3nhf2bN7rMOji3znx=7uuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Ard Biesheuvel @ 2015-01-20 16:20 UTC (permalink / raw) To: Ivan Khoronzhuk, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming Cc: Linaro Kernel Mailman List, Linaro UEFI Mailman List On 20 January 2015 at 16:12, Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: > There is no reason to translate guid number to string here. > So remove it in order to not do unneeded work. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > --- > drivers/firmware/efi/efi.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index 9035c1b..f6be017 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -272,15 +272,10 @@ static __init int match_config_table(efi_guid_t *guid, > unsigned long table, > efi_config_table_type_t *table_types) > { > - u8 str[EFI_VARIABLE_GUID_LEN + 1]; > int i; > > if (table_types) { > - efi_guid_unparse(guid, str); > - > for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) { > - efi_guid_unparse(&table_types[i].guid, str); > - > if (!efi_guidcmp(*guid, table_types[i].guid)) { > *(table_types[i].ptr) = table; > pr_cont(" %s=0x%lx ", Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CAKv+Gu87L6xhEbTiWSdcY6RCk3yc3nhf2bN7rMOji3znx=7uuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [Linaro-uefi] [PATCH] firmware: efi: remove unneeded guid unparse [not found] ` <CAKv+Gu87L6xhEbTiWSdcY6RCk3yc3nhf2bN7rMOji3znx=7uuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-01-20 16:39 ` Leif Lindholm [not found] ` <20150120163908.GS3827-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Leif Lindholm @ 2015-01-20 16:39 UTC (permalink / raw) To: Ard Biesheuvel Cc: Ivan Khoronzhuk, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming, Linaro Kernel Mailman List, Linaro UEFI Mailman List On Tue, Jan 20, 2015 at 04:20:10PM +0000, Ard Biesheuvel wrote: > On 20 January 2015 at 16:12, Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: > > There is no reason to translate guid number to string here. > > So remove it in order to not do unneeded work. > > > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > > --- > > drivers/firmware/efi/efi.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > > index 9035c1b..f6be017 100644 > > --- a/drivers/firmware/efi/efi.c > > +++ b/drivers/firmware/efi/efi.c > > @@ -272,15 +272,10 @@ static __init int match_config_table(efi_guid_t *guid, > > unsigned long table, > > efi_config_table_type_t *table_types) > > { > > - u8 str[EFI_VARIABLE_GUID_LEN + 1]; > > int i; > > > > if (table_types) { > > - efi_guid_unparse(guid, str); > > - > > for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) { > > - efi_guid_unparse(&table_types[i].guid, str); > > - > > if (!efi_guidcmp(*guid, table_types[i].guid)) { > > *(table_types[i].ptr) = table; > > pr_cont(" %s=0x%lx ", Doh! Left the unparses in after I removed the debug printouts :| Thanks for spotting. Acked-by: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> / Leif ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20150120163908.GS3827-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>]
* Re: [Linaro-uefi] [PATCH] firmware: efi: remove unneeded guid unparse [not found] ` <20150120163908.GS3827-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org> @ 2015-01-20 22:32 ` Matt Fleming 0 siblings, 0 replies; 3+ messages in thread From: Matt Fleming @ 2015-01-20 22:32 UTC (permalink / raw) To: Leif Lindholm Cc: Ard Biesheuvel, Ivan Khoronzhuk, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming, Linaro Kernel Mailman List, Linaro UEFI Mailman List On Tue, 20 Jan, at 04:39:08PM, Leif Lindholm wrote: > > Doh! Left the unparses in after I removed the debug printouts :| > Thanks for spotting. > > Acked-by: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Thanks everyone. Applied with ACKs for v3.20. -- Matt Fleming, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-20 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1421770352-5059-1-git-send-email-ivan.khoronzhuk@linaro.org>
[not found] ` <1421770352-5059-1-git-send-email-ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-01-20 16:20 ` [Linaro-uefi] [PATCH] firmware: efi: remove unneeded guid unparse Ard Biesheuvel
[not found] ` <CAKv+Gu87L6xhEbTiWSdcY6RCk3yc3nhf2bN7rMOji3znx=7uuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-20 16:39 ` Leif Lindholm
[not found] ` <20150120163908.GS3827-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
2015-01-20 22:32 ` Matt Fleming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox