From: Borislav Petkov <bp@suse.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Kosina <jkosina@suse.cz>, Kees Cook <keescook@chromium.org>,
Yinghai Lu <yinghai@kernel.org>,
Matt Fleming <matt.fleming@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly
Date: Sun, 1 Mar 2015 20:39:29 +0100 [thread overview]
Message-ID: <20150301193929.GB7748@pd.tnic> (raw)
In-Reply-To: <20150301152351.GA17391@gmail.com>
On Sun, Mar 01, 2015 at 04:23:51PM +0100, Ingo Molnar wrote:
> I think that's a different bug.
>
> parse_kaslr_setup() is simply bogus, it does:
>
> kaslr_enabled = (bool)(pa_data + sizeof(struct setup_data));
Well, we found that while debugging the other issue too:
https://lkml.kernel.org/r/20150228105049.GA11038@pd.tnic
Scroll to the end.
> So I'm inclined to apply Yinghai's fix, with a better changelog that
> explains what happened ...
>
> Agreed?
Yes, this fix needs a commit message which actually explains what's it
fixing before it gets applied.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-03-01 19:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 2:17 [PATCH 0/8] x86, boot: clean up setup_data handling Yinghai Lu
2015-03-01 2:17 ` [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly Yinghai Lu
2015-03-02 9:39 ` Jiri Kosina
[not found] ` <1425176259-30087-2-git-send-email-yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-03-01 2:40 ` Yinghai Lu
2015-03-01 9:45 ` Borislav Petkov
2015-03-01 15:23 ` Ingo Molnar
2015-03-01 19:27 ` Yinghai Lu
2015-03-01 19:49 ` Borislav Petkov
[not found] ` <20150301194904.GC7748-fF5Pk5pvG8Y@public.gmane.org>
2015-03-01 20:24 ` Yinghai Lu
[not found] ` <CAE9FiQVpWQ1NU5Euy2G4btS=94qKCZZ7T0YFsCR1x6iv4C1hjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-01 20:29 ` Borislav Petkov
2015-03-01 20:41 ` Yinghai Lu
[not found] ` <CAE9FiQWqfpCg5reKP5TOv=8qJCLxqBDHCKAexH94avZ4b3=irQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-02 8:56 ` Borislav Petkov
[not found] ` <20150302085654.GA17532-fF5Pk5pvG8Y@public.gmane.org>
2015-03-02 11:04 ` Yinghai Lu
2015-03-02 14:53 ` Borislav Petkov
2015-03-02 18:58 ` Yinghai Lu
2015-03-02 20:25 ` Borislav Petkov
[not found] ` <20150302202507.GD17532-fF5Pk5pvG8Y@public.gmane.org>
2015-03-02 22:10 ` Yinghai Lu
2015-03-01 19:39 ` Borislav Petkov [this message]
2015-03-02 13:13 ` Matt Fleming
2015-03-01 2:17 ` [PATCH 2/8] x86: Kill E820_RESERVED_KERN Yinghai Lu
2015-03-01 2:17 ` [PATCH 3/8] x86, efi: copy SETUP_EFI data and access directly Yinghai Lu
2015-03-01 2:17 ` [PATCH 4/8] x86, of: let add_dtb reserve by itself Yinghai Lu
2015-03-01 2:17 ` [PATCH 5/8] x86, boot: Add add_pci handler for SETUP_PCI Yinghai Lu
[not found] ` <1425176259-30087-1-git-send-email-yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-03-01 2:17 ` [PATCH 6/8] x86: kill not used setup_data handling code Yinghai Lu
2015-03-01 2:17 ` [PATCH 7/8] x86, pci: convert SETUP_PCI data to list Yinghai Lu
2015-03-01 2:17 ` [PATCH 8/8] x86, pci: export SETUP_PCI data via sysfs Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150301193929.GB7748@pd.tnic \
--to=bp@suse.de \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox