From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Yinghai Lu <yinghai@kernel.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] EFI urgent fixes
Date: Mon, 2 Mar 2015 13:35:14 +0000 [thread overview]
Message-ID: <20150302133514.GE24476@codeblueprint.co.uk> (raw)
In-Reply-To: <20150302132410.GA4300@gmail.com>
On Mon, 02 Mar, at 02:24:10PM, Ingo Molnar wrote:
>
> Pulled, thanks Matt!
>
> For future reference, plase leave out unreadable commit messages like
> this:
>
> While adding support loading kernel and initrd above 4G to grub2 in
> legacy mode, I was referring to efi_high_alloc(). That will allocate
> buffer for kernel and then initrd, and initrd will use kernel buffer
> start as limit.
>
> During testing found two buffers will be overlapped when initrd size
> is very big like 400M.
>
> I pulled it, because you do explain the commit in the second half of
> the changelog, in parentheses - but instead of forcing readers through
> the crappy part, please just drop the crappy explanation and fix it
> up, or require your contributors to submit proper changelogs. (Yinghai
> Lu is a repeat offender in that area.)
Noted, I'll be sure to do this in the future. Thanks Ingo!
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-03-02 13:35 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 12:51 [GIT PULL] EFI urgent fixes Matt Fleming
[not found] ` <20150302125104.GC24476-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-03-02 13:24 ` Ingo Molnar
2015-03-02 13:35 ` Matt Fleming [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 21:06 Matt Fleming
[not found] ` <20150730210643.GM2725-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-31 7:56 ` Ingo Molnar
2015-05-05 16:27 Matt Fleming
[not found] ` <20150505162755.GA3767-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-05-06 6:31 ` Ingo Molnar
2015-02-18 11:55 Matt Fleming
[not found] ` <20150218115543.GA5648-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-02-18 13:43 ` Ingo Molnar
[not found] ` <20150218134357.GA386-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-18 16:36 ` Ard Biesheuvel
[not found] ` <D0B4679E-92EB-4A22-8D3E-9D0C27A09ACD-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-02-18 16:57 ` Ingo Molnar
2014-09-25 7:31 Matt Fleming
[not found] ` <20140925073133.GQ18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-25 14:41 ` Ingo Molnar
[not found] ` <20140925144127.GA3828-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-25 14:44 ` Matt Fleming
2014-09-26 11:27 ` Paul Bolle
2014-09-26 11:35 ` Ingo Molnar
[not found] ` <20140926113510.GA14625-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-26 12:24 ` Matt Fleming
[not found] ` <20140926122405.GW18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-27 5:49 ` Ingo Molnar
2014-09-26 11:44 ` Matt Fleming
[not found] ` <20140926114454.GV18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-26 11:59 ` Paul Bolle
2014-09-26 12:34 ` Matt Fleming
2014-09-26 12:55 ` Paul Bolle
[not found] ` <20140926123429.GX18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-27 8:04 ` Valentin Rothberg
[not found] ` <CAD3Xx4JmkDZ1Cw02DFAE0fa0EaEmBi8-W-p7JCfEXLERK5yuUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-27 9:59 ` Paul Bolle
2014-09-08 21:55 Matt Fleming
[not found] ` <20140908215535.GD18582-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-09 5:07 ` Ingo Molnar
[not found] ` <20140909050749.GB6770-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-09 7:07 ` Matt Fleming
2014-09-09 14:55 ` Ingo Molnar
2014-08-22 7:52 Matt Fleming
[not found] ` <20140822075221.GK29733-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-22 8:15 ` Ingo Molnar
2014-07-14 12:54 Matt Fleming
2014-06-27 14:51 Matt Fleming
2014-06-04 16:53 Matt Fleming
2014-04-11 7:16 Matt Fleming
[not found] ` <20140411071622.GB17021-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-04-11 8:27 ` Ingo Molnar
2014-02-14 13:08 Matt Fleming
2013-11-29 12:09 Matt Fleming
2013-07-11 11:16 Matt Fleming
2013-06-07 11:50 Matt Fleming
[not found] ` <20130607115046.GN30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-10 21:36 ` Matt Fleming
2013-05-17 10:18 Matt Fleming
2013-04-25 8:49 Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302133514.GE24476@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=hpa@zytor.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).