Re: [PATCH] Revert "x86/mm/ASLR: Propagate base load address calculation"

Jiri Kosina
2015-03-16T13:56:11Z

On Mon, 16 Mar 2015, Borislav Petkov wrote:

> On Sat, Mar 14, 2015 at 10:59:23AM +0100, Borislav Petkov wrote:
> > In addition to what you've said, I have only one proposal: we revert
> > the whole crap and do it again, this time nice and clean in tip. It'll
> > stay there as long as it has to. No half-arsed commit messages, no
> > misunderstood crap, no lala code f*ckery. Whatever it takes, as long as
> > it takes.
>
> And here it is:
>
> ---
> From: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
> Date: Mon, 16 Mar 2015 10:57:56 +0100
> Subject: [PATCH] Revert "x86/mm/ASLR: Propagate base load address calculation"
>
> This reverts commit f47233c2d34f243ecdaac179c3408a39ff9216a7.
>
> The main reason for the revert is that in order to make this work, we
> need non-trivial changes to the x86 boot code which we didn't manage to
> get done in time for merging.
>
> And even if we did, they would've been too risky so instead of rushing
> things and break booting 4.1 on boxes left and right, we will be very
> strict and conservative and will take our time with this to fix and test
> it properly.
>
> Signed-off-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
> Cc: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>

Agreed. Let's work on a better refresh for 4.1+. The fix attempts were
quite chaotic.

Acked-by: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>

--
Jiri Kosina
SUSE Labs