From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [patch] efi: efivar_create_sysfs_entry() should return negative error codes Date: Mon, 27 Apr 2015 17:31:25 +0100 Message-ID: <20150427163125.GD5042@codeblueprint.co.uk> References: <20150421092153.GA12098@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150421092153.GA12098@mwanda> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Carpenter Cc: Matt Fleming , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Tue, 21 Apr, at 12:21:53PM, Dan Carpenter wrote: > It's not very normal to return 1 on failure and 0 on success. There > isn't a reason for it here, the callers don't care so long as it's > non-zero on failure. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Matt Fleming, Intel Open Source Technology Center