From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v2] efi: dmi: List SMBIOS3 table before SMBIOS table Date: Thu, 30 Apr 2015 17:04:01 +0100 Message-ID: <20150430160401.GF3014@codeblueprint.co.uk> References: <20150430152305.26b89bd3@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150430152305.26b89bd3-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ard Biesheuvel , Leif Lindholm , Matt Fleming , "Ivan.khoronzhuk" List-Id: linux-efi@vger.kernel.org On Thu, 30 Apr, at 03:23:05PM, Jean Delvare wrote: > The SMBIOS3 table should appear before the SMBIOS table in > /sys/firmware/efi/systab. This allows user-space utilities which > support both to pick the SMBIOS3 table with a single pass on systems > where both are implemented. The SMBIOS3 entry point is more capable > than the SMBIOS entry point so it should be preferred. > > This follows the same logic as the ACPI20 table being listed before > the ACPI table. > > Signed-off-by: Jean Delvare > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Matt Fleming > --- > Changes since v1: > * Added a comment explaining why SMBIOS3 must be listed before SMBIOS, > so that it doesn't get accidentally broken in the future. > > drivers/firmware/efi/efi.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks Jean. This looks OK to me but I'd really like to see some ACKs from Leif, Ard or Ivan. -- Matt Fleming, Intel Open Source Technology Center