Re: [PATCH v2] efi: dmi: List SMBIOS3 table before SMBIOS table

[Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>]

On Wed, 27 May 2015 14:18:57 +0100, Matt Fleming wrote:
> On Wed, 27 May, at 12:30:37PM, Ard Biesheuvel wrote:
> > 
> > OK. Then I guess we should at least document in
> > Documentation/ABI/stable/sysfs-firmware-efi-systab that the order in
> > which the entries are enumerated is part of the ABI.
> 
> Makes perfect sense to me. How about this?
> 
> ---
> 
> From ccb5f08bb71ae4199c75668c6beacd6b47fa186c Mon Sep 17 00:00:00 2001
> From: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Wed, 27 May 2015 14:14:22 +0100
> Subject: [PATCH] efi: Add 'systab' information to Documentation/ABI
> 
> It's not clear right now that the order in which entries are displayed
> in /sys/firmware/efi/systab actually forms an ABI that userspace tools
> rely upon.
> 
> Document the ABI along with the userspace tool that cares.
> 
> Suggested-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
> Cc: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Ivan Khoronzhuk <ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
> Signed-off-by: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>  Documentation/ABI/testing/sysfs-firmware-efi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-firmware-efi b/Documentation/ABI/testing/sysfs-firmware-efi
> index 05874da7ce80..e794eac32a90 100644
> --- a/Documentation/ABI/testing/sysfs-firmware-efi
> +++ b/Documentation/ABI/testing/sysfs-firmware-efi
> @@ -18,3 +18,13 @@ Contact:	Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>  Description:	It shows the physical address of config table entry in the EFI
>  		system table.
>  Users:		Kexec
> +
> +What:		/sys/firmware/efi/systab
> +Date:		April 2005
> +Contact:	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> +Description:	Displays the physical addresses of all EFI Configuration
> +		Tables found via the EFI System Table. The order in
> +		which the tables are printed forms an ABI and newer
> +		versions are always printed first, i.e. ACPI20 comes
> +		before ACPI.
> +Users:		dmidecode

Reviewed-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>

Thank you,
-- 
Jean Delvare
SUSE L3 Support