From: Matt Fleming <matt@codeblueprint.co.uk>
To: Dave Young <dyoung@redhat.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
josh@joshtriplett.org, Matt Fleming <matt.fleming@intel.com>,
x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm, efi: Check for valid image type
Date: Thu, 30 Jul 2015 14:02:35 +0100 [thread overview]
Message-ID: <20150730130235.GF2725@codeblueprint.co.uk> (raw)
In-Reply-To: <20150729093752.GF31695@dhcp-128-89.nay.redhat.com>
On Wed, 29 Jul, at 05:37:52PM, Dave Young wrote:
>
> Not sure if BGRT is useful in kexec kernel, it seems not worth to copy
> it between kernels.
>
> IMO just return in case if (efi_setup) is true make sense.
Yes, I think it makes sense to skip touching the BGRT on kexec boot.
As a side note, we should really look at using one of the efi_enabled()
bits to signal when we're booting a kexec'd kernel because it is not at
all obvious that 'efi_setup != 0' means we're in kexec kernel.
But that wants to be a separate patch from this issue.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-07-30 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 15:32 [PATCH] x86/mm, efi: Check for valid image type Sebastian Andrzej Siewior
[not found] ` <1437579164-20176-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-07-28 20:51 ` Matt Fleming
[not found] ` <20150728205157.GD2773-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-29 0:10 ` josh-iaAMLnmF4UmaiuxdJuQwMA
2015-07-29 8:30 ` Sebastian Andrzej Siewior
[not found] ` <55B88F3B.2000902-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-07-29 9:37 ` Dave Young
2015-07-30 13:02 ` Matt Fleming [this message]
2015-07-29 16:41 ` Josh Triplett
2015-07-30 16:33 ` Sebastian Andrzej Siewior
[not found] ` <55BA51E5.3070601-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-07-30 19:09 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730130235.GF2725@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=bigeasy@linutronix.de \
--cc=dyoung@redhat.com \
--cc=josh@joshtriplett.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).