linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: fupan.li@windriver.com, linux-kernel@vger.kernel.org,
	fupanli@gmail.com, linux-efi@vger.kernel.org,
	Luis Henriques <luis.henriques@canonical.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH 3.10 ~ 3.14] efi: fix the efi 32bit boot failed problem
Date: Thu, 30 Jul 2015 09:59:43 -0700	[thread overview]
Message-ID: <20150730165943.GD5515@kroah.com> (raw)
In-Reply-To: <20150730164544.GL2725@codeblueprint.co.uk>

On Thu, Jul 30, 2015 at 05:45:44PM +0100, Matt Fleming wrote:
> On Thu, 30 Jul, at 09:31:02AM, Greg KH wrote:
> > 
> > Why isn't this an issue in newer kernel releases?  Did this already get
> > fixed by some other patch?  If so, why can't we just take that patch?
> > If not, why not?
>  
> The commit 35d5134b7d5a ("x86/efi: Correct EFI boot stub use of
> code32_start") only exists in the stable trees in that form because
> there was quite a lot of churn in that area in Linus tree that didn't
> get backported.
> 
> So the code in Linus' tree never looked like the code in the stable does
> right now.
> 
> > I _REALLY_ don't like taking patches that are not already in Linus's
> > tree, as it almost always turns out to be the wrong solution.
> 
> Yeah, I think this issue verifies that.

Ugh, what a mess.  Ok, if you get something that works and is in a
format that I can apply it, please resend it properly so that we can do
so.

thanks,

greg k-h

  reply	other threads:[~2015-07-30 16:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1438078879-24705-1-git-send-email-fupan.li@windriver.com>
2015-07-30 15:04 ` [PATCH 3.10 ~ 3.14] efi: fix the efi 32bit boot failed problem Matt Fleming
2015-07-30 16:31   ` Greg KH
     [not found]     ` <20150730163102.GA19943-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-30 16:45       ` Matt Fleming
2015-07-30 16:59         ` Greg KH [this message]
     [not found]           ` <20150730165943.GD5515-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-31  1:22             ` fupan
2015-07-31 12:05               ` Matt Fleming
2015-07-31 12:21                 ` Luis Henriques
2015-08-03  1:38                   ` fupan
2015-08-03  2:12                 ` fupan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730165943.GD5515@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fupan.li@windriver.com \
    --cc=fupanli@gmail.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis.henriques@canonical.com \
    --cc=matt@codeblueprint.co.uk \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).