From mboxrd@z Thu Jan 1 00:00:00 1970 From: joeyli Subject: Re: [RFC PATCH 02/16] x86/efi: Add get and set variable to EFI services pointer table Date: Fri, 31 Jul 2015 18:14:52 +0800 Message-ID: <20150731101452.GE13113@linux-rxt1.site> References: <1437056730-15247-1-git-send-email-jlee@suse.com> <1437056730-15247-3-git-send-email-jlee@suse.com> <1438269598.11322.2.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1438269598.11322.2.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: "Lee, Chun-Yi" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Pavel Machek , Josh Boyer , Vojtech Pavlik , Jiri Kosina , "H. Peter Anvin" List-Id: linux-efi@vger.kernel.org On Thu, Jul 30, 2015 at 04:19:58PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > Add get variable and set variable function to EFI services pointer > > table for supporting later functions of hibernate signature > > verification to keep the HMAC key in efi boot service veriable. > > > > Signed-off-by: Lee, Chun-Yi > > Maybe mention that we want to be able to read/write variables from > within the EFI boot stub? That's really why you want to add > {get,set}_variable pointers. > I will add more detail for accessing efi boot service variable is because that will not touched by unauthenticated codes. > s/veriable/variable/ > I will fix the typo. > Rest of the patch looks good. > Thanks a lot! Joey Lee