From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
Cc: Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>,
joeyli <jlee-IBi9RG/b67k@public.gmane.org>,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: efi: Auto-load the efi-pstore module
Date: Wed, 7 Oct 2015 22:16:32 +0100 [thread overview]
Message-ID: <20151007211632.GC3249@codeblueprint.co.uk> (raw)
In-Reply-To: <1443401056.2517.27.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
On Mon, 28 Sep, at 01:44:16AM, Ben Hutchings wrote:
> efi-pstore should be auto-loaded on EFI systems, same as efivars.
>
> Signed-off-by: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
> ---
> This was included in Debian 8 "jessie" with no complaints so far
> (and without CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE set), so it seems
> to be safe to do.
>
> Ben.
>
> --- a/drivers/firmware/efi/efi-pstore.c
> +++ b/drivers/firmware/efi/efi-pstore.c
> @@ -400,3 +400,4 @@ module_exit(efivars_pstore_exit);
>
> MODULE_DESCRIPTION("EFI variable backend for pstore");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:efivars");
I'm OK with this change because it still relies on distributions to
actually enable the Kconfig option too, before it works.
Folks on Cc, please let me know if you have concerns.
--
Matt Fleming, Intel Open Source Technology Center
prev parent reply other threads:[~2015-10-07 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 0:44 efi: Auto-load the efi-pstore module Ben Hutchings
[not found] ` <1443401056.2517.27.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2015-10-07 21:16 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007211632.GC3249@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
--cc=jlee-IBi9RG/b67k@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).