Re: [PATCH] efi: remove UEFIv2.5 properties table from /sys/firmware/efi/systab

[Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]

On Thu, 01 Oct, at 11:15:05AM, Dave Young wrote:
> On 09/30/15 at 04:43pm, Ard Biesheuvel wrote:
> > As pointed out by Dave Young, /sys/firmware/efi/systab violates the
> > sysfs one-value-per-file policy already, so adding more data items
> > to it should be avoided. So let's remove the PROP= line that lists
> > the address of the recently introduced Properties Table before it
> > appears in a release.
> > 
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> > 
> > Matt pointed out that there still needs to be a way for kexec/x86 to
> > access this data, since it needs to pass it on to the kexec kernel.
> > That is way out of my area of expertise, so I will leave it to you
> > to come up with something suitable there.
> > 
> >  drivers/firmware/efi/efi.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > index 2eb31e28a35c..3804ecd4a77a 100644
> > --- a/drivers/firmware/efi/efi.c
> > +++ b/drivers/firmware/efi/efi.c
> > @@ -109,8 +109,6 @@ static ssize_t systab_show(struct kobject *kobj,
> >  		str += sprintf(str, "BOOTINFO=0x%lx\n", efi.boot_info);
> >  	if (efi.uga != EFI_INVALID_TABLE_ADDR)
> >  		str += sprintf(str, "UGA=0x%lx\n", efi.uga);
> > -	if (efi.properties_table != EFI_INVALID_TABLE_ADDR)
> > -		str += sprintf(str, "PROP=0x%lx\n", efi.properties_table);
> >  
> >  	return str - buf;
> >  }
> 
> Ard, thanks, it looks good to me.
> 
> Acked-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Thanks guys. I've folded this into the existing properties table patch
from Ard, because there's no sense in having it as a separate patch
and since that would make backporting more difficult.

-- 
Matt Fleming, Intel Open Source Technology Center