From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() Date: Wed, 11 Nov 2015 16:59:47 +0000 Message-ID: <20151111165947.GD4889@codeblueprint.co.uk> References: <337377a3fbcf855d6a5217e06fcd8c8a979f2853.1446869434.git.geliangtang@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geliang Tang Cc: Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang > --- > drivers/firmware/efi/efi-pstore.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c > index eac76a7..62d57d8 100644 > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) > > static __exit void efivars_pstore_exit(void) > { > + if (!efi_pstore_info.bufsize) > + return; > + > + pstore_unregister(&efi_pstore_info); > + kfree(efi_pstore_info.buf); > + efi_pstore_info.buf = NULL; > + efi_pstore_info.bufsize = 0; > } > > module_init(efivars_pstore_init); Looks OK to me. Kees, are you picking this up?