From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 1/3] arm64: efistub: drop __init annotation from handle_kernel_image() Date: Wed, 3 Feb 2016 15:19:27 +0000 Message-ID: <20160203151927.GJ2597@codeblueprint.co.uk> References: <1453979254-25374-1-git-send-email-ard.biesheuvel@linaro.org> <1453979254-25374-2-git-send-email-ard.biesheuvel@linaro.org> <20160128225809.GF2571@codeblueprint.co.uk> <20160129160006.GD2611@codeblueprint.co.uk> <20160202110821.GB2642@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Leif Lindholm , Will Deacon , Catalin Marinas , Mark Rutland , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Tue, 02 Feb, at 12:09:41PM, Ard Biesheuvel wrote: > On 2 February 2016 at 12:08, Matt Fleming wrote: > > > > What about, > > > > #define __init __compiletime_error("__init not supported in EFI boot stub") > > > > That only works for invocations, i.e., it needs to be used in header > files, and will trigger the error if a call to the function remains > after optimization. We want it at function definition time instead. Good point. OK, how about we just do the #undef, call it good, and I add the task of printing some helpful error message to my growing TODO list?