From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH] efi: libstub: add strnlen() implementation Date: Thu, 18 Feb 2016 13:33:37 +0000 Message-ID: <20160218133337.GF2651@codeblueprint.co.uk> References: <1455636559-7542-1-git-send-email-ard.biesheuvel@linaro.org> <20160218110446.GD2651@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Thu, 18 Feb, at 12:05:51PM, Ard Biesheuvel wrote: > On 18 February 2016 at 12:04, Matt Fleming wrote: > > On Tue, 16 Feb, at 04:29:19PM, Ard Biesheuvel wrote: > >> Commit 91feabc2e224 ("scripts/dtc: Update to upstream commit > >> b06e55c88b9b") introduces references to the strnlen() string function, > >> which is not currently defined in the EFI stub. So add it to our string.c > >> > >> Signed-off-by: Ard Biesheuvel > >> --- > >> drivers/firmware/efi/libstub/string.c | 16 ++++++++++++++++ > >> 1 file changed, 16 insertions(+) > > > > Does this patch fix a build failure for ARM? Which tree is the above > > commit in? > > It is in -next, and it will break the build once it hits upstream. OK, could you resend and include the build failure in the commit log and make a reference to fixing a build issue?