From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Leif Lindholm
<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Baicar, Tyler" <tbaicar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
Subject: Re: [PATCH v2 1/2] efi: esrt: use memremap not ioremap to access ESRT table in memory
Date: Tue, 1 Mar 2016 23:30:40 +0000 [thread overview]
Message-ID: <20160301233040.GA31476@codeblueprint.co.uk> (raw)
In-Reply-To: <20160226144114.GA7475-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
On Fri, 26 Feb, at 02:41:14PM, Matt Fleming wrote:
> On Thu, 18 Feb, at 02:16:24PM, Peter Jones wrote:
> >
> > So the question I have is: would you rather chop up regions and reserve
> > the space, or allocate a new copy and update the configuration table
> > (after ExitBootServices()) to point to it? The latter makes it pretty
> > easy to do from an API that all these drivers can use, and it makes the
> > kexec case completely transparent.
> >
> > Up to you.
>
> I think it makes the most sense to chop up the regions we care about
> (i.e. the ones we have drivers for) because not only does that save us
> the effort of copying out the data on every kexec reboot, it also
> prevents us from leaking each copy since we don't free them at the
> moment.
>
> Then we just need to maintain a separate list of regions to free in
> efi_free_boot_services() or have some other way to distinguish between
> them.
>
> Oh, and save_runtime_map() would need updating to save Boot Services
> regions too.
I have a very rough draft of patches that implement this strategy on
the 'experiemntal/efi-memmap' branch in the EFI tree if anyone is
curious and wants to take a look. The series will be sent out soon.
I wouldn't necessarily try running them or anything as there's a few
things that I know are broken; ia64 build, EFI mixed mode boot,
probably arm64 regressions.
The upshot of the patch series is that there's a whole lot of code we
can share for manipulating memory maps between all EFI architectures
and by fixing this "reserve boot services regions" in a generic way it
should mean kexec under EFI on arm64 should be fairly trivial to
implement, along with ESRT, etc.
next prev parent reply other threads:[~2016-03-01 23:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 11:32 [PATCH v2 0/2] efi: ARM/arm64: wire up ESRT table Ard Biesheuvel
[not found] ` <1455535953-5056-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-15 11:32 ` [PATCH v2 1/2] efi: esrt: use memremap not ioremap to access ESRT table in memory Ard Biesheuvel
[not found] ` <1455535953-5056-2-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-15 15:45 ` Peter Jones
2016-02-16 19:19 ` Baicar, Tyler
2016-02-18 10:44 ` Matt Fleming
[not found] ` <20160218104407.GC2651-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-02-18 12:16 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_AW7PKJJOd2mbEu3LKJe+gNaPHnH=sgO=YXM_KWFyKxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-18 13:28 ` Matt Fleming
[not found] ` <20160218132824.GE2651-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-02-18 13:29 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-s1pzYBzuDG-Z7s3gyo8dPOfeidZQ+rim-uAWZCBcKQQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-18 13:43 ` Matt Fleming
[not found] ` <20160218134324.GG2651-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-02-18 13:44 ` Ard Biesheuvel
[not found] ` <CAKv+Gu875r9RkDC723kNsG4XC0eSE9RPPmSFZrD0sx0QxS+V4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-18 14:15 ` Matt Fleming
[not found] ` <20160218141544.GH2651-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-02-18 14:21 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8RP21vw1Ht7UtkHsen2GMUNx8DikH-hLaezV+uZvWO-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-18 14:38 ` Matt Fleming
2016-02-19 9:27 ` Dave Young
2016-02-18 19:16 ` Peter Jones
[not found] ` <20160218191624.GA1515-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-26 14:41 ` Matt Fleming
[not found] ` <20160226144114.GA7475-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-01 23:30 ` Matt Fleming [this message]
[not found] ` <20160301233040.GA31476-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-01 23:31 ` Matt Fleming
2016-03-02 1:16 ` Dave Young
[not found] ` <20160302011619.GA3192-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2016-03-02 10:23 ` Matt Fleming
2016-03-04 6:25 ` Dave Young
[not found] ` <20160304062524.GA19010-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2016-05-18 8:36 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_ekP+44FJjR7BY_MFqx2jQgc6Tk9W4SBL__ttdvQ55VQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-18 8:53 ` Matt Fleming
[not found] ` <20160518085348.GG21993-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-06-16 13:47 ` Ard Biesheuvel
2016-06-20 11:49 ` Matt Fleming
2016-02-15 11:32 ` [PATCH v2 2/2] arm64/efi: esrt: add missing call to efi_esrt_init() Ard Biesheuvel
[not found] ` <1455535953-5056-3-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-15 15:46 ` Peter Jones
2016-02-16 20:25 ` Baicar, Tyler
[not found] ` <56C385D3.3090308-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-02-17 8:32 ` Ard Biesheuvel
2016-05-17 20:36 ` Christopher Covington
-- strict thread matches above, loose matches on Subject: below --
2016-07-11 19:00 [PATCH v2 0/2] efi/arm*: wire up ESRT table Ard Biesheuvel
[not found] ` <1468263646-28184-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-11 19:00 ` [PATCH v2 1/2] efi: esrt: use memremap not ioremap to access ESRT table in memory Ard Biesheuvel
[not found] ` <1468263646-28184-2-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-15 15:05 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301233040.GA31476@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tbaicar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).