From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 1/5] ARM: efi: apply strict permissons for UEFI Runtime Services regions Date: Wed, 2 Mar 2016 13:14:31 +0000 Message-ID: <20160302131431.GG2649@codeblueprint.co.uk> References: <1456151158-25849-1-git-send-email-ard.biesheuvel@linaro.org> <1456151158-25849-2-git-send-email-ard.biesheuvel@linaro.org> <20160302114901.GC2649@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: Russell King - ARM Linux , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Prakhya, Sai Praneeth" , Leif Lindholm , Mark Rutland , Peter Jones List-Id: linux-efi@vger.kernel.org On Wed, 02 Mar, at 02:07:36PM, Ard Biesheuvel wrote: > On 2 March 2016 at 12:49, Matt Fleming wrote: > > On Mon, 22 Feb, at 03:25:54PM, Ard Biesheuvel wrote: > >> Recent UEFI versions expose permission attributes for runtime services > >> memory regions, either in the UEFI memory map or in the separate memory > >> attributes table. This allows the kernel to map these regions with > >> stricter permissions, rather than the RWX permissions that are used by > >> default. So wire this up in our mapping routine. > >> > >> Signed-off-by: Ard Biesheuvel > >> --- > >> arch/arm/include/asm/efi.h | 1 + > >> arch/arm/kernel/efi.c | 41 ++++++++++++++++++++ > >> 2 files changed, 42 insertions(+) > > > > Looks fine from an EFI perspective, but it would be nice for somebody > > else with ARM knowledge to ACK it. > > I agree. > > Note that the whole memory attribute series needs to wait for some > memremap() changes that I proposed for ARM (or at least the bits where > we wire it up for arm64+ARM) Thanks for the reminder. I'll definitely hold off on applying this for now.