From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] efi/arm*: use memremap() to create the persistent memmap mapping
Date: Thu, 14 Apr 2016 13:23:05 +0100 [thread overview]
Message-ID: <20160414122305.GO2829@codeblueprint.co.uk> (raw)
In-Reply-To: <CAKv+Gu9GNssCtBY85zMSpGh8bcwXD-3t3LCxmwmK7dO5qN0dzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 14 Apr, at 10:43:45AM, Ard Biesheuvel wrote:
>
> Actually, this patch does not depend on the ARM memremap changes being
> merged: before those changes, memremap() unconditionally falls back to
> ioremap_cache() for 'System RAM' so this patch is essentially a nop in
> that case. This is guaranteed to work due to the fact that we [still]
> use MEMBLOCK_NOMAP for mapping the memory map on ARM.
OK, these two look good to me, so I'm going to queue them up in 'next'
chronologically before your EFI Memory Attributes table patches.
> The memory attributes table and GOP changes do depend on it, however,
> since the configuration tables it accesses are likely to be covered by
> a struct page, in which case ARM disallows the ioremap_cache() (and
> thus the use of memremap() until it is updated to deal with this
> situation explicitly)
>
> The other change that depends on it is dropping the MEMBLOCK_NOMAP for
> ARM as well (as we did in the arm64 patch that is currently queued up
> for v4.6-rc)
Noted. Thanks Ard.
prev parent reply other threads:[~2016-04-14 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 15:37 [PATCH 1/2] efi: check EFI_MEMORY_DESCRIPTOR version explicitly Ard Biesheuvel
[not found] ` <1460561873-27756-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-13 15:37 ` [PATCH 2/2] efi/arm*: use memremap() to create the persistent memmap mapping Ard Biesheuvel
[not found] ` <1460561873-27756-2-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-14 8:43 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9GNssCtBY85zMSpGh8bcwXD-3t3LCxmwmK7dO5qN0dzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-14 12:23 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414122305.GO2829@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).