linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Vaishali Thakkar <vaishali.thakkar@oracle.com>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Saurabh Sengar <saurabh.truth@gmail.com>
Subject: Re: [PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL
Date: Sun, 17 Apr 2016 22:18:35 +0100	[thread overview]
Message-ID: <20160417211835.GY2829@codeblueprint.co.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1604150837040.2061@localhost6.localdomain6>

On Fri, 15 Apr, at 08:38:37AM, Julia Lawall wrote:
> 
> I looked at it a bit with Vaishali.  I wonder if it would be possible at 
> least to have only one flag? Then one wouldn't have to maintain the 
> subtle relationship between atomic and duplicates.  I'm not sure that it 
> would help Coccinelle, but at least one could see more quickly that 
> Coccinelle is giving a false positive.

Yeah, that would be a good idea.

How about we drop the @atomic parameter and simply use @duplicates to
figure out whether to perform duplicate detection, which we should
note in the comment of efivar_init() cannot be performed atomically.
Bonus points if someone can clean up the code flow too.

Otherwise, efivar_init() is done while holding a spinlock.

      reply	other threads:[~2016-04-17 21:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 10:53 [PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL Vaishali Thakkar
     [not found] ` <1460372009-10785-1-git-send-email-vaishali.thakkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-04-14 21:49   ` Matt Fleming
     [not found]     ` <20160414214949.GS2829-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-04-15  6:38       ` Julia Lawall
2016-04-17 21:18         ` Matt Fleming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160417211835.GY2829@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saurabh.truth@gmail.com \
    --cc=vaishali.thakkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).