From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCHv2 0/6] efi: detect erroneous firmware IRQ manipulation Date: Mon, 25 Apr 2016 11:15:27 +0100 Message-ID: <20160425101527.GP2829@codeblueprint.co.uk> References: <1461333083-15529-1-git-send-email-mark.rutland@arm.com> <20160424212241.GO2829@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160424212241.GO2829-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel , Mark Rutland Cc: "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Catalin Marinas , "hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org" , Leif Lindholm , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Russell King - ARM Linux , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org" , Will Deacon List-Id: linux-efi@vger.kernel.org On Sun, 24 Apr, at 10:22:41PM, Matt Fleming wrote: > > I like this series a lot (well, ignoring the fact that the firmware is > trying to eat itself). The runtime call code is much cleaner now, and > this is a great precedent for any future multi-architecture quirks we > may need. > > Queued for v4.7, thanks everyone! Hmm... Booting this series with Qemu and OVMF results in lots of warnings, [ 0.102173] ------------[ cut here ]------------ [ 0.103000] WARNING: CPU: 0 PID: 0 at /dev/shm/mfleming/git/efi/drivers/firmware/efi/runtime-wrappers.c:30 efi_call_virt_check_flags+0x69/0x90 [ 0.103505] Modules linked in: [ 0.104519] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc4+ #1 [ 0.105000] 0000000000000000 ffffffff81e03e30 ffffffff8132206f 0000000000000000 [ 0.105000] 0000000000000000 ffffffff81e03e70 ffffffff8105a47c 0000001e0000000a [ 0.105000] 0000000000000246 0000000000000286 ffffffff81bed975 ffffffff81e03f10 [ 0.105000] Call Trace: [ 0.105000] [] dump_stack+0x4d/0x6e [ 0.105000] [] __warn+0xcc/0xf0 [ 0.105000] [] warn_slowpath_null+0x18/0x20 [ 0.105000] [] efi_call_virt_check_flags+0x69/0x90 [ 0.105000] [] virt_efi_set_variable+0x82/0x190 [ 0.105000] [] efi_delete_dummy_variable+0x75/0x80 [ 0.105000] [] efi_enter_virtual_mode+0x463/0x472 [ 0.105000] [] start_kernel+0x38f/0x415 [ 0.105000] [] ? set_init_arg+0x55/0x55 [ 0.105000] [] x86_64_start_reservations+0x2a/0x2c [ 0.105000] [] x86_64_start_kernel+0xea/0xed [ 0.107181] ---[ end trace 0081cc453369d969 ]--- [ 0.107499] Disabling lock debugging due to kernel taint [ 0.108226] [Firmware Bug]: IRQ flags corrupted (0x00000246=>0x00000286) by EFI set_variable Has anyone tested this series on x86 to ensure that this is a rare case? I'll go and test some physical x86 machines now.