From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: "Compostella,
Jeremy"
<jeremy.compostella-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Stanacar,
Stefan" <stefan.stanacar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] efibc: EFI Bootloader Control
Date: Mon, 25 Apr 2016 13:17:53 +0100 [thread overview]
Message-ID: <20160425121753.GT2829@codeblueprint.co.uk> (raw)
In-Reply-To: <87mvor83tl.fsf-e2kLcBBGnpIIbNWpFUBdLQzuBQEzu/OPQQ4Iyu8u01E@public.gmane.org>
On Mon, 18 Apr, at 03:05:42PM, Jeremy Compostella wrote:
> +static void efibc_set_variable(const char *name, const char *value)
> +{
> + int ret;
> + efi_guid_t guid = EFI_LOADER_GUID;
> + struct efivar_entry entry;
> + size_t size = (strlen(value) + 1) * sizeof(efi_char16_t);
Putting 'entry' on the stack leads to the following build warning,
drivers/firmware/efi/efibc.c: In function ‘efibc_set_variable’:
drivers/firmware/efi/efibc.c:53:1: warning: the frame size of 2192 bytes is larger than 2048 bytes [-Wframe-larger-than=]
That's a big object.
Given that efibc_reboot_notifier_call() can only be invoked once,
could we just statically allocate 'entry' instead?
next prev parent reply other threads:[~2016-04-25 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 13:09 [PATCH] efibc: EFI Bootloader Control Compostella, Jeremy
[not found] ` <87bn5tlbkw.fsf-e2kLcBBGnpIIbNWpFUBdLQzuBQEzu/OPQQ4Iyu8u01E@public.gmane.org>
2016-04-14 16:00 ` Matt Fleming
[not found] ` <20160414160006.GR2829-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-04-18 13:04 ` Compostella, Jeremy
[not found] ` <87r3e383v7.fsf-e2kLcBBGnpIIbNWpFUBdLQzuBQEzu/OPQQ4Iyu8u01E@public.gmane.org>
2016-04-18 13:05 ` Compostella, Jeremy
[not found] ` <87mvor83tl.fsf-e2kLcBBGnpIIbNWpFUBdLQzuBQEzu/OPQQ4Iyu8u01E@public.gmane.org>
2016-04-22 22:44 ` Matt Fleming
2016-04-25 12:17 ` Matt Fleming [this message]
2016-04-22 21:38 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425121753.GT2829@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=jeremy.compostella-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefan.stanacar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).