From: Matt Fleming <matt@codeblueprint.co.uk>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-efi@vger.kernel.org, linux@arm.linux.org.uk,
ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
leif.lindholm@linaro.org, mingo@redhat.com, hpa@zytor.com,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption
Date: Mon, 25 Apr 2016 15:15:57 +0100 [thread overview]
Message-ID: <20160425141557.GA2829@codeblueprint.co.uk> (raw)
In-Reply-To: <571E25B1.8070305@arm.com>
On Mon, 25 Apr, at 03:12:01PM, Robin Murphy wrote:
> >+static void efi_call_virt_check_flags(unsigned long flags, const char *call)
> >+{
> >+ unsigned long cur_flags;
> >+ bool mismatch;
> >+
> >+ local_save_flags(cur_flags);
> >+
> >+ mismatch = !!((cur_flags ^ flags) & ARCH_EFI_IRQ_FLAGS_MASK);
>
> nit: the assignment itself is already a conversion to bool, so the
> excitement is redundant here.
This was intentional. I asked Mark to make this change so that it's
explicit for the developer that we're performing the type conversion.
next prev parent reply other threads:[~2016-04-25 14:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:46 [PATCHv3 0/5] efi: detect erroneous firmware IRQ manipulation Mark Rutland
2016-04-25 13:46 ` [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Mark Rutland
[not found] ` <1461591994-14918-2-git-send-email-mark.rutland-5wv7dgnIgG8@public.gmane.org>
2016-04-25 14:12 ` Robin Murphy
2016-04-25 14:15 ` Matt Fleming [this message]
[not found] ` <20160425141557.GA2829-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-04-25 14:18 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8yH4u0-DNezUTk5b1DQJdEaH4RxR7YMQcwmkuRmEaNEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-25 14:24 ` Matt Fleming
[not found] ` <20160425142435.GB2829-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-04-25 14:27 ` Mark Rutland
2016-04-25 15:59 ` Matt Fleming
2016-04-25 16:03 ` Mark Rutland
2016-04-25 14:33 ` Robin Murphy
2016-04-25 13:46 ` [PATCHv3 2/5] arm64/efi: enable runtime call flag checking Mark Rutland
2016-04-25 13:54 ` Will Deacon
2016-04-25 13:46 ` [PATCHv3 3/5] arm/efi: " Mark Rutland
2016-04-25 13:46 ` [PATCHv3 4/5] x86/efi: " Mark Rutland
2016-04-25 13:46 ` [PATCHv3 5/5] efi/runtime-wrappers: remove ARCH_EFI_IRQ_FLAGS_MASK ifdef Mark Rutland
[not found] ` <1461591994-14918-1-git-send-email-mark.rutland-5wv7dgnIgG8@public.gmane.org>
2016-04-25 16:03 ` [PATCHv3 0/5] efi: detect erroneous firmware IRQ manipulation Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425141557.GA2829@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=hpa@zytor.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).