From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 3/3] efi: Format EFI version prints the way the standard says. Date: Thu, 15 Sep 2016 10:18:22 +0100 Message-ID: <20160915091822.GA16797@codeblueprint.co.uk> References: <20160907122339.GB28333@wunner.de> <1473260186-4500-1-git-send-email-pjones@redhat.com> <1473260186-4500-3-git-send-email-pjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1473260186-4500-3-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Jones Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ard Biesheuvel , Lukas Wunner List-Id: linux-efi@vger.kernel.org On Wed, 07 Sep, at 10:56:26AM, Peter Jones wrote: > We print "EFI v2.xx.yy vendor blahblah" at several places. Make them > conform to the standard format. > > This leaves 2 checkpatch warnings in arch/ia64/kernel/efi.c intact; the > old code would have produced them, and they match the nearby code in the > functions. > > Signed-off-by: Peter Jones > Reviewed-by: Lukas Wunner > --- > arch/ia64/kernel/efi.c | 14 ++++++-------- > arch/x86/platform/efi/efi.c | 20 ++++++++++++-------- > drivers/firmware/efi/arm-init.c | 13 ++++++------- > drivers/firmware/efi/efi.c | 16 +++++++++++++--- > include/linux/efi.h | 2 ++ > 5 files changed, 39 insertions(+), 26 deletions(-) I'm not sure about this one. Booting with this patch on my test VMs I see the old, efi: EFI v2.40 by EDK II now reading, efi: EFI v2.4 by EDK II Yes, the new string is obviously more correct but gratuitous changes to the strings we print on boot have caused trouble in the past. If people have scripts or tests that check the EFI version that gets printed they'll break. Are there any additional supporting reasons for this patch?