From: Matt Fleming <matt@codeblueprint.co.uk>
To: Mike Krinkin <krinkin.m.u@gmail.com>
Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com,
ricardo.neri-calderon@linux.intel.com, ard.biesheuvel@linaro.org,
pjones@redhat.com, scott.lawson@intel.com,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Mike Galbraith <umgwanakikbuti@gmail.com>
Subject: Re: Cannot load linux after recent efi-related changes
Date: Mon, 19 Sep 2016 12:41:53 +0100 [thread overview]
Message-ID: <20160919114153.GD2892@codeblueprint.co.uk> (raw)
In-Reply-To: <20160919113634.GA4140@gmail.com>
On Mon, 19 Sep, at 02:36:36PM, Mike Krinkin wrote:
> On Mon, Sep 19, 2016 at 12:14:24PM +0100, Matt Fleming wrote:
> > On Sun, 18 Sep, at 04:14:45AM, Mike Krinkin wrote:
> > >
> > > diff --git a/drivers/firmware/efi/memmap.c b/drivers/firmware/efi/memmap.c
> > > index cd96086..34322d1 100644
> > > --- a/drivers/firmware/efi/memmap.c
> > > +++ b/drivers/firmware/efi/memmap.c
> > > @@ -221,8 +221,8 @@ void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf,
> > > void *old, *new;
> > >
> > > /* modifying range */
> > > - m_start = mem->range.start;
> > > - m_end = mem->range.end;
> > > + m_start = mem->range.start & ~(u64)EFI_PAGE_SIZE;
> > > + m_end = ALIGN(mem->range.end, EFI_PAGE_SIZE) - 1;
> > > m_attr = mem->attribute;
> > >
> > > for (old = old_memmap->map, new = buf;
> >
> > Thanks for the analysis and patch Mike, but this needs fixing further
> > up the call stack so that we don't map things the caller didn't
> > expect.
> >
> > This bug was also reported in this thread,
> >
> > https://lkml.kernel.org/r/1474005912.3930.10.camel@gmail.com
>
> Sorry, i haven't seen that.
No problem.
> >
> > Could you try this patch?
>
> Works fine for me.
Thanks, I've added your Tested-by.
prev parent reply other threads:[~2016-09-19 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 16:24 Cannot load linux after recent efi-related changes Mike Krinkin
[not found] ` <20160917162357.GA4122-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-18 1:14 ` Mike Krinkin
2016-09-19 11:14 ` Matt Fleming
[not found] ` <20160919111424.GB2892-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-09-19 11:36 ` Mike Krinkin
2016-09-19 11:41 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919114153.GD2892@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=krinkin.m.u@gmail.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjones@redhat.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=scott.lawson@intel.com \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).