From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 3/3] efi/efi_test: fix the uninitialized value rv Date: Mon, 3 Oct 2016 21:25:53 +0100 Message-ID: <20161003202553.GN16071@codeblueprint.co.uk> References: <1474859691-8574-1-git-send-email-ivan.hu@canonical.com> <1474859691-8574-4-git-send-email-ivan.hu@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1474859691-8574-4-git-send-email-ivan.hu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ivan Hu Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ard Biesheuvel List-Id: linux-efi@vger.kernel.org On Mon, 26 Sep, at 11:14:51AM, Ivan Hu wrote: > Fix the minor issue found by CoverityScan > 520 kfree(name); > CID 1358932 (#1 of 1): Uninitialized scalar variable (UNINIT)17. > uninit_use: Using uninitialized value rv. > 521 return rv; > 522} > > Signed-off-by: Ivan Hu > --- > drivers/firmware/efi/test/efi_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c > index 87394f0..39302e6 100644 > --- a/drivers/firmware/efi/test/efi_test.c > +++ b/drivers/firmware/efi/test/efi_test.c > @@ -425,7 +425,7 @@ static long efi_runtime_get_nextvariablename(unsigned long arg) > efi_guid_t *vd = NULL; > efi_guid_t vendor_guid; > efi_char16_t *name = NULL; > - int rv; > + int rv = 0; > > getnextvariablename_user = (struct efi_getnextvariablename __user *)arg; > Thanks, applied to 'next'.