From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: ivanhu <ivan.hu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 1/3] efi/efi_test: use memdup_user() as a cleanup
Date: Tue, 4 Oct 2016 22:37:43 +0100 [thread overview]
Message-ID: <20161004213743.GV16071@codeblueprint.co.uk> (raw)
In-Reply-To: <3fb6d9fa-b554-509b-fc59-d75340017589-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
On Tue, 04 Oct, at 11:04:56AM, ivanhu wrote:
> Hi Matt,
>
> The warning message is from Kbuild test robot,
>
> https://chromium.googlesource.com/linux-fpga-chameleon/+/fpga-chameleon-4.2/scripts/coccinelle/api/memdup_user.cocci,
>
>
> and I believe it tries to persuade us to use memdup_user instead of kmalloc
> and copy_form_user,
>
> With this new function, we don't have to write 'len' twice, which can lead
> to typos/mistakes.
> It also produces smaller code and kernel text.
>
> http://lkml.iu.edu/hypermail/linux/kernel/0903.0/02349.html
Right, I understand all that. My question was specifically about the
following sentence from your patch,
> This is a little bit restricted to reduce false positives
What restriction that reduces false positives are you referring to?
next prev parent reply other threads:[~2016-10-04 21:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 3:14 [PATCH 0/3] efi_test: fix Coccinelle warning and CoverityScan issues Ivan Hu
[not found] ` <1474859691-8574-1-git-send-email-ivan.hu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-09-26 3:14 ` [PATCH 1/3] efi/efi_test: use memdup_user() as a cleanup Ivan Hu
[not found] ` <1474859691-8574-2-git-send-email-ivan.hu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-10-03 20:17 ` Matt Fleming
[not found] ` <20161003201718.GL16071-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-10-04 3:04 ` ivanhu
[not found] ` <3fb6d9fa-b554-509b-fc59-d75340017589-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-10-04 21:37 ` Matt Fleming [this message]
[not found] ` <20161004213743.GV16071-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-10-05 1:31 ` ivanhu
2016-09-26 3:14 ` [PATCH 2/3] efi/efi_test: fix the uninitialized value datasize Ivan Hu
[not found] ` <1474859691-8574-3-git-send-email-ivan.hu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-10-03 20:23 ` Matt Fleming
2016-09-26 3:14 ` [PATCH 3/3] efi/efi_test: fix the uninitialized value rv Ivan Hu
[not found] ` <1474859691-8574-4-git-send-email-ivan.hu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-10-03 20:25 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004213743.GV16071@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ivan.hu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).