Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2]

Mark Rutland
2016-11-23T13:38:55Z

On Wed, Nov 23, 2016 at 11:46:38AM +0000, David Howells wrote:
> Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> > On Wed, Nov 23, 2016 at 12:22:43AM +0000, David Howells wrote:
> > > Provide the ability to perform mixed-mode runtime service calls for arm in
> > > the same way that commit 0a637ee61247bd4bed9b2a07568ef7a1cfc76187
> > > ("x86/efi: Allow invocation of arbitrary boot services") provides the
> > > ability to invoke arbitrary boot services.
> >
> > I'm not sure I understand. On arm/arm64, "mixed-mode" simply isn't possible.
> >
> > I see we already call runtime services directly in efi_get_secureboot()
> > in drivers/firmware/efi/libstub/arm-stub.c.
> >
> > If this is just to provide a consistent API for the stub, please note
> > that.
>
> How about:
>
> arm/efi: Allow invocation of arbitrary runtime services
>
> efi_call_runtime() is provided for x86 to be able abstract mixed mode
> support. Provide this for ARM also so that common code work in mixed mode
> also.

That sounds good to me.

Thanks,
Mark.