Re: [PATCH] efi/libstub/arm*: Set default address and size cells values for an empty dtb

Timur Tabi
2017-02-13T20:51:49Z

On Wed, Feb 8, 2017 at 4:40 AM, Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>
> The point is that the tooling should take *existing* cell counts into
> account: if there are no address-cells/size-cells properties under
> /chosen or under the root node, the tooling should use 32-bit
> quantities for address and size. If there are such properties, it
> should emit reg tuples of the same size as the cells properties
> describe.

I agree with this 100%, but that means that we need to be able to
inject address-cells/size-cells properties at some point, otherwise
we'll never be able to store 64-bit addresses. And that's what
Sameer's patch does. It injects those properties at the appropriate
time. Any code that parses 'reg' properties without taking the
address-cells/size-cells properties into account is technically
incorrect and should be fixed..

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.