linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down
Date: Fri, 7 Apr 2017 11:07:05 +0800	[thread overview]
Message-ID: <20170407030705.GB4296@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <149142333752.5101.12956279967668146884.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>

On 04/05/17 at 09:15pm, David Howells wrote:
> From: Matthew Garrett <matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
> 
> kexec permits the loading and execution of arbitrary code in ring 0, which
> is something that lock-down is meant to prevent. It makes sense to disable
> kexec in this situation.
> 
> This does not affect kexec_file_load() which can check for a signature on the
> image to be booted.
> 
> Signed-off-by: Matthew Garrett <matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> ---
> 
>  kernel/kexec.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 980936a90ee6..46de8e6b42f4 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -194,6 +194,13 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments,
>  		return -EPERM;
>  
>  	/*
> +	 * kexec can be used to circumvent module loading restrictions, so
> +	 * prevent loading in that case
> +	 */
> +	if (kernel_is_locked_down())
> +		return -EPERM;
> +
> +	/*
>  	 * Verify we have a legal set of flags
>  	 * This leaves us room for future extensions.
>  	 */
> 
> 
> _______________________________________________
> kexec mailing list
> kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/kexec

Acked-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Thanks
Dave

  parent reply	other threads:[~2017-04-07  3:07 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 20:14 [PATCH 00/24] Kernel lockdown David Howells
2017-04-05 20:14 ` [PATCH 01/24] efi: Add EFI_SECURE_BOOT bit David Howells
2017-04-06  8:26   ` Ard Biesheuvel
2017-04-06  8:48     ` David Howells
2017-04-05 20:14 ` [PATCH 03/24] efi: Lock down the kernel if booted in secure boot mode David Howells
2017-04-05 20:15 ` [PATCH 04/24] Enforce module signatures if the kernel is locked down David Howells
2017-04-05 20:15 ` [PATCH 05/24] Restrict /dev/mem and /dev/kmem when " David Howells
2017-04-05 20:15 ` [PATCH 06/24] Add a sysrq option to exit secure boot mode David Howells
     [not found]   ` <149142332458.5101.14654616837280513947.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-14 18:05     ` Thomas Gleixner
2017-04-14 18:15       ` Ard Biesheuvel
     [not found]       ` <CAKv+Gu-FDzdqACyr_z6Zsgb51mg8Lc0YgfLs4oGURWnX4WewSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-14 23:16         ` David Howells
2017-04-16 20:46       ` Matt Fleming
2017-04-05 20:15 ` [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down David Howells
     [not found]   ` <149142333752.5101.12956279967668146884.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-07  3:07     ` Dave Young [this message]
2017-04-05 20:15 ` [PATCH 08/24] Copy secure_boot flag in boot params across kexec reboot David Howells
2017-04-05 20:16 ` [PATCH 10/24] hibernate: Disable when the kernel is locked down David Howells
2017-04-05 20:16 ` [PATCH 11/24] uswsusp: " David Howells
     [not found]   ` <149142336965.5101.2946578135980499557.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-05 23:38     ` Rafael J. Wysocki
2017-04-06  6:39       ` Oliver Neukum
2017-04-06  8:41         ` David Howells
     [not found]           ` <14980.1491468060-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-06 20:09             ` Rafael J. Wysocki
2017-04-06 20:12               ` Rafael J. Wysocki
2017-04-06 20:25                 ` Jiri Kosina
2017-04-08  3:28                   ` poma
2017-04-12 13:44                     ` joeyli
2017-04-06  6:55       ` David Howells
2017-04-06 20:07         ` Rafael J. Wysocki
2017-04-05 20:16 ` [PATCH 12/24] PCI: Lock down BAR access " David Howells
     [not found]   ` <149142337836.5101.13971561682218232219.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-18 17:50     ` Bjorn Helgaas
     [not found] ` <149142326734.5101.4596394505987813763.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-05 20:14   ` [PATCH 02/24] Add the ability to lock down access to the running kernel image David Howells
2017-04-05 20:15   ` [PATCH 09/24] kexec_file: Disable at runtime if securelevel has been set David Howells
     [not found]     ` <149142335441.5101.2294976563846442575.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-07  3:05       ` Dave Young
2017-04-07  3:49         ` Mimi Zohar
     [not found]           ` <1491536950.4184.10.camel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-04-07  6:19             ` Dave Young
2017-04-07  7:07               ` David Howells
     [not found]                 ` <21418.1491548875-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-07  7:41                   ` Dave Young
     [not found]                     ` <20170407074159.GB10737-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-04-07  8:28                       ` Mimi Zohar
     [not found]                         ` <1491553688.4184.73.camel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-04-07  8:42                           ` Dave Young
2017-04-07  7:45               ` Mimi Zohar
2017-04-07  8:01                 ` Dave Young
2017-04-07  7:09           ` David Howells
2017-04-07  7:46             ` Mimi Zohar
2017-04-07  9:17               ` David Howells
2017-04-07 12:36                 ` Mimi Zohar
2017-04-10 13:19                   ` David Howells
     [not found]                     ` <13679.1491830392-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-02 19:01                       ` Mimi Zohar
2017-04-05 20:16   ` [PATCH 13/24] x86: Lock down IO port access when the kernel is locked down David Howells
     [not found]     ` <149142338597.5101.14728426552744019377.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-14 18:28       ` Thomas Gleixner
2017-04-05 20:17   ` [PATCH 22/24] Prohibit PCMCIA CIS storage " David Howells
2017-04-05 20:17   ` [PATCH 23/24] Lock down TIOCSSERIAL David Howells
2017-04-05 20:18   ` [PATCH 24/24] Lock down module params that specify hardware parameters (eg. ioport) David Howells
2017-04-05 20:16 ` [PATCH 14/24] x86: Restrict MSR access when the kernel is locked down David Howells
2017-04-14 18:30   ` Thomas Gleixner
2017-04-05 20:16 ` [PATCH 15/24] asus-wmi: Restrict debugfs interface " David Howells
2017-04-07 10:25   ` Andy Shevchenko
2017-04-07 12:50     ` David Howells
2017-04-09 11:10       ` Andy Shevchenko
2017-04-10 13:16         ` David Howells
     [not found]           ` <13615.1491830208-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-18  6:06             ` Andy Shevchenko
2017-04-18 14:34               ` Ben Hutchings
2017-04-18 15:30                 ` David Howells
     [not found]                   ` <16503.1492529434-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-18 17:39                     ` Ben Hutchings
     [not found]               ` <1492526075.2409.140.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2017-04-18 14:55                 ` David Howells
2017-04-18 15:19                   ` Ben Hutchings
     [not found]                   ` <1492528799.2409.145.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2017-04-18 15:34                     ` David Howells
2017-04-05 20:16 ` [PATCH 16/24] ACPI: Limit access to custom_method " David Howells
2017-04-05 20:16 ` [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel has been " David Howells
2017-04-06 19:43   ` Rafael J. Wysocki
2017-04-07  6:31     ` Dave Young
     [not found]     ` <20170407063107.GA10451-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-04-07  7:05       ` David Howells
2017-04-07  7:39         ` Dave Young
2017-04-05 20:17 ` [PATCH 18/24] acpi: Disable ACPI table override if the kernel is " David Howells
2017-04-05 20:17 ` [PATCH 19/24] acpi: Disable APEI error injection " David Howells
2017-04-05 20:17 ` [PATCH 20/24] bpf: Restrict kernel image access functions when " David Howells
2017-04-06 12:29   ` Alexei Starovoitov
2017-04-06 12:40     ` Ard Biesheuvel
2017-04-13  8:46     ` David Howells
     [not found]   ` <149142344547.5101.4518618716303032193.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-12 14:57     ` joeyli
2017-04-05 20:17 ` [PATCH 21/24] scsi: Lock down the eata driver David Howells
2017-04-07 15:59 ` [PATCH 00/24] Kernel lockdown Austin S. Hemmelgarn
     [not found]   ` <25acabf2-ac99-3c2b-ee9a-53d71b5c77f2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-07 16:29     ` Justin Forbes
2017-04-10 23:15   ` Why kernel lockdown? David Howells
  -- strict thread matches above, loose matches on Subject: below --
2017-04-05 17:09 [PATCH 00/24] Kernel lockdown David Howells
2017-04-05 17:10 ` [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down David Howells
2017-04-05 17:07 [PATCH 00/24] Kernel lockdown David Howells
     [not found] ` <149141201983.30815.1240162780237131881.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-05 17:08   ` [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407030705.GB4296@dhcp-128-65.nay.redhat.com \
    --to=dyoung-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).