* [PATCH] efi: remove duplicate 'const' specifiers
@ 2017-05-11 11:43 Arnd Bergmann
2017-05-11 13:41 ` Ard Biesheuvel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-05-11 11:43 UTC (permalink / raw)
To: Matt Fleming, Ard Biesheuvel
Cc: Arnd Bergmann, Ingo Molnar, David Howells, Josh Boyer,
linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
gcc-7 shows a harmless warning:
drivers/firmware/efi/libstub/secureboot.c:19:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
static const efi_char16_t const efi_SecureBoot_name[] = {
drivers/firmware/efi/libstub/secureboot.c:22:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
Removing one of the specifiers gives us the expected behavior.
Fixes: de8cb458625c ("efi: Get and store the secure boot status")
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
---
drivers/firmware/efi/libstub/secureboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/efi/libstub/secureboot.c b/drivers/firmware/efi/libstub/secureboot.c
index 8c34d50a4d80..959777ec8a77 100644
--- a/drivers/firmware/efi/libstub/secureboot.c
+++ b/drivers/firmware/efi/libstub/secureboot.c
@@ -16,10 +16,10 @@
/* BIOS variables */
static const efi_guid_t efi_variable_guid = EFI_GLOBAL_VARIABLE_GUID;
-static const efi_char16_t const efi_SecureBoot_name[] = {
+static const efi_char16_t efi_SecureBoot_name[] = {
'S', 'e', 'c', 'u', 'r', 'e', 'B', 'o', 'o', 't', 0
};
-static const efi_char16_t const efi_SetupMode_name[] = {
+static const efi_char16_t efi_SetupMode_name[] = {
'S', 'e', 't', 'u', 'p', 'M', 'o', 'd', 'e', 0
};
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] efi: remove duplicate 'const' specifiers
2017-05-11 11:43 [PATCH] efi: remove duplicate 'const' specifiers Arnd Bergmann
@ 2017-05-11 13:41 ` Ard Biesheuvel
[not found] ` <20170511114337.2803599-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-05-15 14:22 ` Matt Fleming
2 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2017-05-11 13:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Matt Fleming, Ingo Molnar, David Howells, Josh Boyer,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
On 11 May 2017 at 12:43, Arnd Bergmann <arnd@arndb.de> wrote:
> gcc-7 shows a harmless warning:
>
> drivers/firmware/efi/libstub/secureboot.c:19:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> static const efi_char16_t const efi_SecureBoot_name[] = {
> drivers/firmware/efi/libstub/secureboot.c:22:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>
> Removing one of the specifiers gives us the expected behavior.
>
> Fixes: de8cb458625c ("efi: Get and store the secure boot status")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/firmware/efi/libstub/secureboot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/secureboot.c b/drivers/firmware/efi/libstub/secureboot.c
> index 8c34d50a4d80..959777ec8a77 100644
> --- a/drivers/firmware/efi/libstub/secureboot.c
> +++ b/drivers/firmware/efi/libstub/secureboot.c
> @@ -16,10 +16,10 @@
>
> /* BIOS variables */
> static const efi_guid_t efi_variable_guid = EFI_GLOBAL_VARIABLE_GUID;
> -static const efi_char16_t const efi_SecureBoot_name[] = {
> +static const efi_char16_t efi_SecureBoot_name[] = {
> 'S', 'e', 'c', 'u', 'r', 'e', 'B', 'o', 'o', 't', 0
> };
> -static const efi_char16_t const efi_SetupMode_name[] = {
> +static const efi_char16_t efi_SetupMode_name[] = {
> 'S', 'e', 't', 'u', 'p', 'M', 'o', 'd', 'e', 0
> };
>
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <20170511114337.2803599-1-arnd-r2nGTMty4D4@public.gmane.org>]
* Re: [PATCH] efi: remove duplicate 'const' specifiers
[not found] ` <20170511114337.2803599-1-arnd-r2nGTMty4D4@public.gmane.org>
@ 2017-05-11 15:41 ` David Howells
0 siblings, 0 replies; 4+ messages in thread
From: David Howells @ 2017-05-11 15:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA, Matt Fleming, Ard Biesheuvel,
Ingo Molnar, Josh Boyer, linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> gcc-7 shows a harmless warning:
>
> drivers/firmware/efi/libstub/secureboot.c:19:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> static const efi_char16_t const efi_SecureBoot_name[] = {
> drivers/firmware/efi/libstub/secureboot.c:22:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>
> Removing one of the specifiers gives us the expected behavior.
>
> Fixes: de8cb458625c ("efi: Get and store the secure boot status")
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Reviewed-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] efi: remove duplicate 'const' specifiers
2017-05-11 11:43 [PATCH] efi: remove duplicate 'const' specifiers Arnd Bergmann
2017-05-11 13:41 ` Ard Biesheuvel
[not found] ` <20170511114337.2803599-1-arnd-r2nGTMty4D4@public.gmane.org>
@ 2017-05-15 14:22 ` Matt Fleming
2 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2017-05-15 14:22 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ard Biesheuvel, Ingo Molnar, David Howells, Josh Boyer, linux-efi,
linux-kernel
On Thu, 11 May, at 01:43:17PM, Arnd Bergmann wrote:
> gcc-7 shows a harmless warning:
>
> drivers/firmware/efi/libstub/secureboot.c:19:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> static const efi_char16_t const efi_SecureBoot_name[] = {
> drivers/firmware/efi/libstub/secureboot.c:22:27: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>
> Removing one of the specifiers gives us the expected behavior.
>
> Fixes: de8cb458625c ("efi: Get and store the secure boot status")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/firmware/efi/libstub/secureboot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the urgent queue.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-15 14:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 11:43 [PATCH] efi: remove duplicate 'const' specifiers Arnd Bergmann
2017-05-11 13:41 ` Ard Biesheuvel
[not found] ` <20170511114337.2803599-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-05-11 15:41 ` David Howells
2017-05-15 14:22 ` Matt Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).