From: Lukas Wunner <lukas@wunner.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
Ashok Raj <ashok.raj@intel.com>,
linux-pci <linux-pci@vger.kernel.org>,
Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] efi/cper: Fix endianness of PCI class code
Date: Fri, 26 May 2017 12:45:55 +0200 [thread overview]
Message-ID: <20170526104555.GB4744@wunner.de> (raw)
In-Reply-To: <CAK8P3a0YthR69OFGzVqsPoGv3UEGFA9jnedubwQtZj-v0LzQQA@mail.gmail.com>
On Fri, May 26, 2017 at 10:01:28AM +0200, Arnd Bergmann wrote:
> On Fri, May 26, 2017 at 8:08 AM, Lukas Wunner <lukas@wunner.de> wrote:
> > On Thu, May 25, 2017 at 06:07:35AM -0700, Ard Biesheuvel wrote:
> >> On 25 May 2017 at 05:56, Lukas Wunner <lukas@wunner.de> wrote:
> >> >> Or does 'guarantee' mean 'I tested it and it works'?
> >> >
> >> > I tested it with x86_64 (le) and ppc32 (be) and it works.
> >> > I don't have an aarch64 machine available here.
> >>
> >> Good.
> >
> > Good to merge then?
>
> Please remove the bit fields and find a way to do the patch without them.
> We really don't want any bitfields in structures that are interpreted by
> hardware:
This structure is not interpreted by hardware.
Thanks,
Lukas
next prev parent reply other threads:[~2017-05-26 10:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 18:38 [PATCH] efi/cper: Fix endianness of PCI class code Lukas Wunner
[not found] ` <771bc335fb5856792d086ae7db288dcf244cb4cd.1493964354.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-06 7:46 ` Ard Biesheuvel
2017-05-06 9:07 ` Lukas Wunner
2017-05-10 8:03 ` Ard Biesheuvel
2017-05-10 8:12 ` Arnd Bergmann
2017-05-10 8:41 ` Lukas Wunner
2017-05-11 14:06 ` Ard Biesheuvel
[not found] ` <CAKv+Gu81gvNL1jkb3T35=-5fr_x-BmSg9X2CcQ97xv5JTZ-c1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-11 14:48 ` David Daney
2017-05-25 12:30 ` Lukas Wunner
[not found] ` <20170525123047.GA4172-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-25 12:36 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_3vYKGOrzC8+Y3QwXOtV8Tbm8HC7nzQCdKVB1Qbdoriw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25 12:44 ` Lukas Wunner
2017-05-25 12:47 ` Ard Biesheuvel
2017-05-25 12:56 ` Lukas Wunner
[not found] ` <20170525125650.GA4196-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-25 13:07 ` Ard Biesheuvel
2017-05-26 6:08 ` Lukas Wunner
2017-05-26 8:01 ` Arnd Bergmann
2017-05-26 10:45 ` Lukas Wunner [this message]
2017-05-26 9:16 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_fbNSK+LuWmQGqLHtu3rF9BdYwNB+K-myNXS=X+goXkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-26 10:43 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526104555.GB4744@wunner.de \
--to=lukas@wunner.de \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=ashok.raj@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox