* [PATCH] efi: add comment to avoid future expanding of sysfs systab
@ 2017-12-05 9:42 Dave Young
[not found] ` <20171205094227.GA16630-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Dave Young @ 2017-12-05 9:42 UTC (permalink / raw)
To: Ard Biesheuvel, Matt Fleming
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r
/sys/firmware/efi/systab shows several different values, it breaks sysfs
one file one value design. But since there are already userspace tools
depend on it eg. kexec-tools so add code comment to alert future expanding
of this file.
Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
drivers/firmware/efi/efi.c | 2 ++
1 file changed, 2 insertions(+)
--- linux-x86.orig/drivers/firmware/efi/efi.c
+++ linux-x86/drivers/firmware/efi/efi.c
@@ -109,6 +109,8 @@ struct kobject *efi_kobj;
/*
* Let's not leave out systab information that snuck into
* the efivars driver
+ * Note, do not add more fields in systab sysfs file as it breaks sysfs
+ * one value per file rule!
*/
static ssize_t systab_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] efi: add comment to avoid future expanding of sysfs systab
[not found] ` <20171205094227.GA16630-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
@ 2017-12-05 10:16 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-12-05 10:16 UTC (permalink / raw)
To: Dave Young
Cc: Ard Biesheuvel, Matt Fleming, linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Tue, Dec 05, 2017 at 05:42:27PM +0800, Dave Young wrote:
> /sys/firmware/efi/systab shows several different values, it breaks sysfs
> one file one value design. But since there are already userspace tools
> depend on it eg. kexec-tools so add code comment to alert future expanding
> of this file.
>
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-05 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05 9:42 [PATCH] efi: add comment to avoid future expanding of sysfs systab Dave Young
[not found] ` <20171205094227.GA16630-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-05 10:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).