public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
To: Andy Shevchenko
	<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Ard Biesheuvel
	<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] efi/apple-properties: Device core takes care of empty properties
Date: Mon, 22 Jan 2018 22:46:09 +0100	[thread overview]
Message-ID: <20180122214609.GA18579@wunner.de> (raw)
In-Reply-To: <20180122141709.41898-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

On Mon, Jan 22, 2018 at 04:17:09PM +0200, Andy Shevchenko wrote:
> There is no need to artificially supply a property length and fake data
> if property has type of boolean.

You're right, I just didn't know better.

I've verified that with this patch applied, boolean properties are
still listed with the "dump_apple_properties" command line option
and I've also tested that it's still possible to test presence of
boolean properties with device_property_present(), so FWIW:

Reviewed-and-tested-by: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>

Thanks Andy!  Ard, could you pick this up please?

Kind regards,

Lukas

  parent reply	other threads:[~2018-01-22 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 14:17 [PATCH v1] efi/apple-properties: Device core takes care of empty properties Andy Shevchenko
     [not found] ` <20180122141709.41898-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-01-22 21:46   ` Lukas Wunner [this message]
     [not found]     ` <20180122214609.GA18579-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-01-23 18:50       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122214609.GA18579@wunner.de \
    --to=lukas-jfq808j9c/izqb+pc5nmwq@public.gmane.org \
    --cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox