From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH v1] efi/apple-properties: Device core takes care of empty properties Date: Mon, 22 Jan 2018 22:46:09 +0100 Message-ID: <20180122214609.GA18579@wunner.de> References: <20180122141709.41898-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180122141709.41898-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko Cc: Ard Biesheuvel , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Mon, Jan 22, 2018 at 04:17:09PM +0200, Andy Shevchenko wrote: > There is no need to artificially supply a property length and fake data > if property has type of boolean. You're right, I just didn't know better. I've verified that with this patch applied, boolean properties are still listed with the "dump_apple_properties" command line option and I've also tested that it's still possible to test presence of boolean properties with device_property_present(), so FWIW: Reviewed-and-tested-by: Lukas Wunner Thanks Andy! Ard, could you pick this up please? Kind regards, Lukas