From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v2 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures Date: Tue, 27 Feb 2018 18:06:54 +0100 Message-ID: <20180227170654.GL26382@pd.tnic> References: <20180226193904.20532-1-Yazen.Ghannam@amd.com> <20180226193904.20532-6-Yazen.Ghannam@amd.com> <20180227150356.GH26382@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Ghannam, Yazen" Cc: "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ard.biesheuvel@linaro.org" , "x86@kernel.org" List-Id: linux-efi@vger.kernel.org On Tue, Feb 27, 2018 at 03:33:44PM +0000, Ghannam, Yazen wrote: > I agree which is why I've included the Validation Bits. A user can then > check the Validation Bits for any field that is of interest but missing. No, no half-baked fields. So you know drivers/edac/mce_amd.c, right? And you know the lengths we go to make an error record as readable as possible? So please apply the same logic and intent here too. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --