From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
ard.biesheuvel@linaro.org, x86@kernel.org, tony.luck@intel.com
Subject: Re: [PATCH v3 3/8] efi: Decode IA32/X64 Processor Error Info Structure
Date: Thu, 29 Mar 2018 12:54:49 +0200 [thread overview]
Message-ID: <20180329105448.GB29198@pd.tnic> (raw)
In-Reply-To: <20180324184940.19762-4-Yazen.Ghannam@amd.com>
On Sat, Mar 24, 2018 at 01:49:35PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> Print the fields in the IA32/X64 Processor Error Info Structure.
>
> Based on UEFI 2.7 Table 253. IA32/X64 Processor Error Information
> Structure.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> Link:
> https://lkml.kernel.org/r/20180226193904.20532-4-Yazen.Ghannam@amd.com
>
> v2->v3:
> * Fix table number in commit message.
> * Don't print raw validation bits.
>
> v1->v2:
> * Add parantheses around "bits" expression in macro.
> * Fix indentation on multi-line statements.
>
> drivers/firmware/efi/cper-x86.c | 50 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c
> index 863f0cd2a0ff..a9ab3bbf7986 100644
> --- a/drivers/firmware/efi/cper-x86.c
> +++ b/drivers/firmware/efi/cper-x86.c
> @@ -3,15 +3,28 @@
>
> #include <linux/cper.h>
>
> +#define INDENT_SP " "
There's that thing again. So it was a total waste of time discussing
this last time. So let me save my time this time:
NAKed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-03-29 10:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 18:49 [PATCH v3 0/8] Decode IA32/X64 CPER Yazen Ghannam
2018-03-24 18:49 ` [PATCH v3 1/8] efi: Fix IA32/X64 Processor Error Record definition Yazen Ghannam
2018-03-24 18:49 ` [PATCH v3 2/8] efi: Decode IA32/X64 Processor Error Section Yazen Ghannam
2018-03-29 9:46 ` Borislav Petkov
2018-03-29 13:47 ` Ghannam, Yazen
2018-03-24 18:49 ` [PATCH v3 3/8] efi: Decode IA32/X64 Processor Error Info Structure Yazen Ghannam
2018-03-29 10:54 ` Borislav Petkov [this message]
2018-03-29 13:53 ` Ghannam, Yazen
2018-03-30 11:25 ` Ard Biesheuvel
2018-04-02 13:21 ` Ghannam, Yazen
2018-04-02 13:22 ` Ard Biesheuvel
2018-03-24 18:49 ` [PATCH v3 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs Yazen Ghannam
2018-03-24 18:49 ` [PATCH v3 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures Yazen Ghannam
2018-03-24 18:49 ` [PATCH v3 6/8] efi: Decode additional IA32/X64 Bus Check fields Yazen Ghannam
2018-03-24 18:49 ` [PATCH v3 7/8] efi: Decode IA32/X64 MS Check structure Yazen Ghannam
2018-03-24 18:49 ` [PATCH v3 8/8] efi: Decode IA32/X64 Context Info structure Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329105448.GB29198@pd.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox