Linux EFI development
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: akpm@linux-foundation.org, ard.biesheuvel@linaro.org,
	aryabinin@virtuozzo.com, akataria@vmware.com,
	boris.ostrovsky@oracle.com, brijesh.singh@amd.com,
	caoj.fnst@cn.fujitsu.com, gregkh@linuxfoundation.org,
	hpa@zytor.com, jan.kiszka@siemens.com,
	jarkko.sakkinen@linux.intel.com, jgross@suse.com,
	jpoimboe@redhat.com, kirill.shutemov@linux.intel.com,
	mingo@redhat.com, mjg59@google.com, mka@chromium.org,
	ndesaulniers@google.com, pombredanne@nexb.com,
	rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com,
	tweek@google.com
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, virtualization@lists.linux-foundation.org,
	astrachan@google.com, manojgupta@google.com,
	ghackmann@google.com, sedat.dilek@gmail.com, tstellar@redhat.com,
	keescook@google.com, yamada.masahiro@socionext.com,
	michal.lkml@markovi.net, linux-kbuild@vger.kernel.org,
	geert@linux-m68k.org, will.deacon@arm.com,
	mawilcox@microsoft.com, arnd@arndb.de, rientjes@google.com
Subject: [PATCH v2 0/2] extern inline native_save_fl for paravirt
Date: Tue,  5 Jun 2018 10:05:30 -0700	[thread overview]
Message-ID: <20180605170532.170361-1-ndesaulniers@google.com> (raw)

paravirt depends on a custom calling convention (callee saved), but
expects this from a static inline function that it then forces to be
outlined. This is problematic because different compilers or flags can
then add a stack guard that violates the calling conventions.

Uses extern inline with the out-of-line definition in assembly to
prevent compilers from adding stack guards to the outlined version.

Other parts of the codebase overwrite KBUILD_CFLAGS, which is *extremely
problematic* for extern inline, as the sematics are completely the
opposite depending on what C standard is used.
http://blahg.josefsipek.net/?p=529

Changes since v2:
  Prefer gnu_inline function attribute instead of explicitly setting C
  standard compiler flag in problematic Makefiles. We should instead
  carefully evaluate if those Makefiles should be overwriting
  KBUILD_CFLAGS at all. Dropped the previous first two patches and added
  a new first patch.

Nick Desaulniers (2):
  compiler-gcc.h: add gnu_inline to all inline declarations
  x86: paravirt: make native_save_fl extern inline

 arch/x86/include/asm/irqflags.h |  2 +-
 arch/x86/kernel/Makefile        |  1 +
 arch/x86/kernel/irqflags.S      | 26 ++++++++++++++++++++++++++
 include/linux/compiler-gcc.h    | 19 +++++++++++++------
 4 files changed, 41 insertions(+), 7 deletions(-)
 create mode 100644 arch/x86/kernel/irqflags.S

-- 
2.17.1.1185.g55be947832-goog

             reply	other threads:[~2018-06-05 17:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 17:05 Nick Desaulniers [this message]
2018-06-05 17:05 ` [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations Nick Desaulniers
2018-06-05 17:23   ` Joe Perches
2018-06-05 17:55     ` Nick Desaulniers
2018-06-05 19:13     ` Joe Perches
2018-06-05 19:50       ` Nick Desaulniers
2018-06-05 21:59         ` Joe Perches
2018-06-06  8:05       ` Sedat Dilek
2018-06-06 16:39         ` hpa
2018-06-08 14:34           ` Sedat Dilek
2018-06-07 17:26     ` Nick Desaulniers
2018-06-07 17:29       ` Nick Desaulniers
2018-06-07 18:31       ` Joe Perches
2018-06-07 18:51         ` Nick Desaulniers
2018-06-07 17:33     ` Nick Desaulniers
2018-06-05 17:05 ` [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
2018-06-05 17:28   ` H. Peter Anvin
2018-06-05 17:31     ` H. Peter Anvin
2018-06-05 17:46       ` Sedat Dilek
2018-06-05 17:52       ` Nick Desaulniers
2018-06-05 18:06         ` H. Peter Anvin
2018-06-05 21:28   ` Arnd Bergmann
2018-06-05 21:31     ` Arnd Bergmann
2018-06-05 21:51       ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605170532.170361-1-ndesaulniers@google.com \
    --to=ndesaulniers@google.com \
    --cc=akataria@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=aryabinin@virtuozzo.com \
    --cc=astrachan@google.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=brijesh.singh@amd.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=geert@linux-m68k.org \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgross@suse.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manojgupta@google.com \
    --cc=mawilcox@microsoft.com \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=mjg59@google.com \
    --cc=mka@chromium.org \
    --cc=pombredanne@nexb.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=sedat.dilek@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tstellar@redhat.com \
    --cc=tweek@google.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox