From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alistair Strachan Subject: [PATCH] efi/libstub: arm: support building with clang Date: Thu, 9 Aug 2018 09:40:42 -0700 Message-ID: <20180809164042.210675-1-astrachan@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: Stefan Agner , Ard Biesheuvel , Will Deacon , Greg Kroah-Hartman , Russell King , linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-efi@vger.kernel.org When building with CONFIG_EFI and CONFIG_EFI_STUB on ARM, the libstub Makefile would use -mno-single-pic-base without checking it was supported by the compiler. As the ARM (32-bit) clang backend does not support this flag, the build would fail. This changes the Makefile to check the compiler's support for -mno-single-pic-base before using it, similar to c1c386681bd7 ("ARM: 8767/1: add support for building ARM kernel with clang"). Cc: Stefan Agner Cc: Ard Biesheuvel Cc: Will Deacon Cc: Greg Kroah-Hartman Cc: Russell King Cc: linux-efi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Alistair Strachan --- drivers/firmware/efi/libstub/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile index a34e9290a699..91339d13f2a1 100644 --- a/drivers/firmware/efi/libstub/Makefile +++ b/drivers/firmware/efi/libstub/Makefile @@ -13,7 +13,8 @@ cflags-$(CONFIG_X86) += -m$(BITS) -D__KERNEL__ -O2 \ cflags-$(CONFIG_ARM64) := $(subst -pg,,$(KBUILD_CFLAGS)) -fpie cflags-$(CONFIG_ARM) := $(subst -pg,,$(KBUILD_CFLAGS)) \ - -fno-builtin -fpic -mno-single-pic-base + -fno-builtin -fpic \ + $(call cc-option,-mno-single-pic-base) cflags-$(CONFIG_EFI_ARMSTUB) += -I$(srctree)/scripts/dtc/libfdt -- 2.18.0.597.ga71716f1ad-goog