From: Ingo Molnar <mingo@kernel.org>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: ard.biesheuvel@linaro.org, tglx@linutronix.de, x86@kernel.org,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/efi: earlyprintk - Add 64bit efi fb address support
Date: Mon, 10 Sep 2018 09:20:28 +0200 [thread overview]
Message-ID: <20180910072028.GA47768@gmail.com> (raw)
In-Reply-To: <1536423828-5693-1-git-send-email-aaron.ma@canonical.com>
* Aaron Ma <aaron.ma@canonical.com> wrote:
> if (efi_fb)
> return (efi_fb + start);
Just noticed this detail unrelated to your patch: return is not a function.
Thanks,
Ingo
next prev parent reply other threads:[~2018-09-10 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 16:23 [PATCH] x86/efi: earlyprintk - Add 64bit efi fb address support Aaron Ma
2018-09-10 7:20 ` Ingo Molnar [this message]
2018-09-12 15:00 ` Ard Biesheuvel
2018-09-12 15:09 ` Aaron Ma
2018-09-12 18:00 ` [PATCH v2] " Aaron Ma
2018-09-12 18:39 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910072028.GA47768@gmail.com \
--to=mingo@kernel.org \
--cc=aaron.ma@canonical.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).