From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Fan Subject: Re: [PATCH v9 2/8] x86/boot: Copy kstrtoull() to compressed period Date: Thu, 18 Oct 2018 14:08:47 +0800 Message-ID: <20181018060846.GH12871@localhost.localdomain> References: <20181017102012.872-1-fanc.fnst@cn.fujitsu.com> <20181017102012.872-3-fanc.fnst@cn.fujitsu.com> <20181018040338.GC1885@192.168.1.4> <20181018055158.GD12871@localhost.localdomain> <20181018060128.GH1885@192.168.1.4> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20181018060128.GH1885@192.168.1.4> Sender: linux-kernel-owner@vger.kernel.org To: Baoquan He Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, keescook@chromium.org, msys.mizuma@gmail.com, indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com List-Id: linux-efi@vger.kernel.org On Thu, Oct 18, 2018 at 02:01:28PM +0800, Baoquan He wrote: >On 10/18/18 at 01:51pm, Chao Fan wrote: >> On Thu, Oct 18, 2018 at 12:03:38PM +0800, Baoquan He wrote: >> >On 10/17/18 at 06:20pm, Chao Fan wrote: >> >> Copy kstrtoull() to 'compressed' directory so that >> >> we can use it to change the address in cmdline from >> >> string to unsigned long long. >> > >> >So you don't like simple_strtoull() in arch/x86/boot/string.c which has >> >been used in boot/compressed/kaslr.c . Why? Are you going to clean up >> >simple_strtoull()? >> >> Boris told me use the new function in old version's review. >> Both work well for me. > >OK, then maybe you can clear simple_strtoull() out in a separate patch >since you have introduced a new one. Or after this patchset. Yes, after this patchset, some cleanup will be needed. Thanks, Chao Fan > >