From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: Add support for TCG2 log format on UEFI systems Date: Tue, 2 Apr 2019 02:52:45 +0300 Message-ID: <20190401235245.GA29282@linux.intel.com> References: <20190227202658.197113-1-matthewgarrett@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190227202658.197113-1-matthewgarrett@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Matthew Garrett , tomas.winkler@intel.com Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca, roberto.sassu@huawei.com, linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, tweek@google.com List-Id: linux-efi@vger.kernel.org On Wed, Feb 27, 2019 at 12:26:54PM -0800, Matthew Garrett wrote: > Identical to V4, but based on tpmdd-next OK, so on my GLK NUC I get valid final log and invalid event log after adding some extra klogs. I.e. - if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) + if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) { + pr_err("No event log\n"); return -ENODEV; + } will result [ 2.654392] No event log but still [ 0.000000] efi: ACPI 2.0=0x69ca2000 ACPI=0x69ca2000 TPMFinalLog=0x69ce4000 SMBIOS=0x69f63000 SMBIOS 3.0=0x69f62000 ESRT=0x69f3e818 MEMATTR=0x63475118 Tomas, I wonder if you are able to get the log out with some machine? /Jarkko