From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A644C04AB5 for ; Thu, 6 Jun 2019 13:22:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24C6520868 for ; Thu, 6 Jun 2019 13:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559827374; bh=5DCnBlqkLCaf0QybhtzTbl/dW/HgkItPQ7Y1kIO+cog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JM+BuOcrMeT6CBWSp0A6ujmLRDuU4dI1YV0+v58yfPJDk9cdYckScRKWqKXw4KhZ9 0JdP7e8VWixBN2oz10jJek3QD1PhRmGFbQCuULrNaj26YiN6h/lur3Mhm72DonqanD yTO8HYe2PuHBYz6RPKrtzdoOBWSi9avzXjs57H0w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726958AbfFFNWx (ORCPT ); Thu, 6 Jun 2019 09:22:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:51130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfFFNWx (ORCPT ); Thu, 6 Jun 2019 09:22:53 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96EA520866; Thu, 6 Jun 2019 13:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559827372; bh=5DCnBlqkLCaf0QybhtzTbl/dW/HgkItPQ7Y1kIO+cog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xqop9KNyMyK39T6+MJ6Y3ZVxBI59s3koY6SaRwBpWEMFhjVm9x0ThRrrMaYyvSpfW lOcY8NbumVbUej6opAk3Xxoj0u+8j7XYDbtCjxg0wPM7kGSYIkAMTy30tw3eAiv6CF hW2eB+UNR/6D7MtU6z3jidFgwo82ejE3nzDToYVo= Date: Thu, 6 Jun 2019 09:22:51 -0400 From: Sasha Levin To: Ard Biesheuvel Cc: eb@emlix.com, linux-efi@vger.kernel.org, gregkh@linuxfoundation.org, stable@vger.kernel.org, ndesaulniers@google.com Subject: Re: [PATCH for-4.9-stable] efi/libstub: Unify command line param parsing Message-ID: <20190606132251.GK29739@sasha-vm> References: <20190606102513.16321-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190606102513.16321-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Thu, Jun 06, 2019 at 12:25:13PM +0200, Ard Biesheuvel wrote: >Commit 60f38de7a8d4e816100ceafd1b382df52527bd50 upstream. > >Merge the parsing of the command line carried out in arm-stub.c with >the handling in efi_parse_options(). Note that this also fixes the >missing handling of CONFIG_CMDLINE_FORCE=y, in which case the builtin >command line should supersede the one passed by the firmware. > >Signed-off-by: Ard Biesheuvel >Cc: Linus Torvalds >Cc: Matt Fleming >Cc: Peter Zijlstra >Cc: Thomas Gleixner >Cc: bhe@redhat.com >Cc: bhsharma@redhat.com >Cc: bp@alien8.de >Cc: eugene@hp.com >Cc: evgeny.kalugin@intel.com >Cc: jhugo@codeaurora.org >Cc: leif.lindholm@linaro.org >Cc: linux-efi@vger.kernel.org >Cc: mark.rutland@arm.com >Cc: roy.franz@cavium.com >Cc: rruigrok@codeaurora.org >Link: http://lkml.kernel.org/r/20170404160910.28115-1-ard.biesheuvel@linaro.org >Signed-off-by: Ingo Molnar >[ardb: fix up merge conflicts with 4.9.180] >Signed-off-by: Ard Biesheuvel >--- >This fixes the GCC build issue reported by Eike. > >Note that testing of arm64 stable kernels should cover CONFIG_RANDOMIZE_BASE, >since it has a profound impact on how the kernel binary gets put together. Should this fix be applied to 4.9 as well? I see it in 4.14+ -- Thanks, Sasha