Re: [PATCH for-4.9-stable] efi/libstub: Unify command line param parsing

Ard Biesheuvel
2019-06-06T13:33:18Z

On Thu, 6 Jun 2019 at 15:22, Sasha Levin <sashal@kernel.org> wrote:
>
> On Thu, Jun 06, 2019 at 12:25:13PM +0200, Ard Biesheuvel wrote:
> >Commit 60f38de7a8d4e816100ceafd1b382df52527bd50 upstream.
> >
> >Merge the parsing of the command line carried out in arm-stub.c with
> >the handling in efi_parse_options(). Note that this also fixes the
> >missing handling of CONFIG_CMDLINE_FORCE=y, in which case the builtin
> >command line should supersede the one passed by the firmware.
> >
> >Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >Cc: Linus Torvalds <torvalds@linux-foundation.org>
> >Cc: Matt Fleming <matt@codeblueprint.co.uk>
> >Cc: Peter Zijlstra <peterz@infradead.org>
> >Cc: Thomas Gleixner <tglx@linutronix.de>
> >Cc: bhe@redhat.com
> >Cc: bhsharma@redhat.com
> >Cc: bp@alien8.de
> >Cc: eugene@hp.com
> >Cc: evgeny.kalugin@intel.com
> >Cc: jhugo@codeaurora.org
> >Cc: leif.lindholm@linaro.org
> >Cc: linux-efi@vger.kernel.org
> >Cc: mark.rutland@arm.com
> >Cc: roy.franz@cavium.com
> >Cc: rruigrok@codeaurora.org
> >Link: http://lkml.kernel.org/r/20170404160910.28115-1-ard.biesheuvel@linaro.org
> >Signed-off-by: Ingo Molnar <mingo@kernel.org>
> >[ardb: fix up merge conflicts with 4.9.180]
> >Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >---
> >This fixes the GCC build issue reported by Eike.
> >
> >Note that testing of arm64 stable kernels should cover CONFIG_RANDOMIZE_BASE,
> >since it has a profound impact on how the kernel binary gets put together.
>
> Should this fix be applied to 4.9 as well?
>
> I see it in 4.14+
>

I don't understand this question. The fix is proposed for v4.9 because
it fixes a build error with GCC that was caused by a backport of one
of the clang enablement patches.