From: <Narendra.K@dell.com>
To: <ard.biesheuvel@linaro.org>
Cc: <Mario.Limonciello@dell.com>, <linux-efi@vger.kernel.org>,
<pjones@redhat.com>, <Stuart.Hayes@dell.com>
Subject: Re: [PATCH v1] Export Runtime Configuration Interface table to sysfs
Date: Thu, 8 Aug 2019 19:03:03 +0000 [thread overview]
Message-ID: <20190808190245.GA2270@localhost.localdomain> (raw)
In-Reply-To: <CAKv+Gu8-BTwpFz0dyNDoAP9xhrDQH4Qm0m73uAi2T0ckVrR5tw@mail.gmail.com>
On Thu, Aug 08, 2019 at 11:16:55AM +0300, Ard Biesheuvel wrote:
>
> On Wed, 7 Aug 2019 at 16:09, <Narendra.K@dell.com> wrote:
> > On Thu, Jul 11, 2019 at 11:00:37PM +0000, Limonciello, Mario wrote:
[...]
> > Hi Ard,
> >
> > Does the version 1 of the patch look good ? Please share your thoughts.
> >
>
> Thanks Narendra,
>
> The patch looks mostly fine. I have pushed it to my efi/next branch,
Ard, thank you for the review comments and applying the patch.
> and I will let you know if the autobuilders find any problems.
Ok.
>
> One possible enhancement would be to defer the second memremap() call
> until the first call to raw_table_read(), so the mapping only exists
> if you are actually interested in the contents of the table. If you do
> decide to make any followup changes, please send them as delta patches
> against https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/log/?h=next
Ok. I will work on the enhancement suggestion. Thank you for the
suggestion.
--
With regards,
Narendra K
prev parent reply other threads:[~2019-08-08 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 18:59 [PATCH v1] Export Runtime Configuration Interface table to sysfs Narendra.K
2019-07-11 23:00 ` Mario.Limonciello
2019-08-07 13:09 ` Narendra.K
2019-08-08 8:16 ` Ard Biesheuvel
2019-08-08 19:03 ` Narendra.K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808190245.GA2270@localhost.localdomain \
--to=narendra.k@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=Stuart.Hayes@dell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox