From: <Narendra.K@dell.com>
To: <Narendra.K@dell.com>
Cc: <linux-efi@vger.kernel.org>, <ard.biesheuvel@linaro.org>,
<Mario.Limonciello@dell.com>, <geert@linux-m68k.org>,
<mingo@kernel.org>, <tglx@linutronix.de>, <james.morse@arm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
Date: Sun, 13 Oct 2019 19:15:03 +0000 [thread overview]
Message-ID: <20191013191450.GA2792@localhost.localdomain> (raw)
In-Reply-To: <20191013185643.GA2583@localhost.localdomain>
Hi Ard,
On Sun, Oct 13, 2019 at 06:57:05PM +0000, K, Narendra wrote:
> From: Narendra K <Narendra.K@dell.com>
>
> For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> for input on platforms where the option may not be applicable. This patch
> modifies the kconfig option to ask the user for input only when CONFIG_X86
> or CONFIG_COMPILE_TEST is set to y.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Narendra K <Narendra.K@dell.com>
> ---
I missed mentioning the following details -
This patch is created on kernel version 5.4-rc2
Changes in v1:
- dropped following changes
'depends on EFI' as it is implied
'default n' as 'n' is the default if not mentioned
splitting 'bool' to 'bool + prompt'
- added dependency on X86 || COMPILE_TEST
- added the 'Reported-by:' and 'Fix-suggested-by:' to give credit to
Geert Uytterhoeven who reported the issue and suggested the fix
> drivers/firmware/efi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 178ee8106828..b248870a9806 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
>
> config EFI_RCI2_TABLE
> bool "EFI Runtime Configuration Interface Table Version 2 Support"
> + depends on X86 || COMPILE_TEST
> help
> Displays the content of the Runtime Configuration Interface
> Table version 2 on Dell EMC PowerEdge systems as a binary
> --
> 2.18.1
>
> --
> With regards,
> Narendra K
--
With regards,
Narendra K
next prev parent reply other threads:[~2019-10-13 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 18:57 [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Narendra.K
2019-10-13 19:15 ` Narendra.K [this message]
2019-10-14 6:41 ` Geert Uytterhoeven
2019-10-14 6:49 ` Ard Biesheuvel
2019-10-14 9:51 ` Narendra.K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013191450.GA2792@localhost.localdomain \
--to=narendra.k@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=geert@linux-m68k.org \
--cc=james.morse@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).