linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Narendra.K@dell.com>
To: <ard.biesheuvel@linaro.org>
Cc: <geert@linux-m68k.org>, <linux-efi@vger.kernel.org>,
	<Mario.Limonciello@dell.com>, <mingo@kernel.org>,
	<tglx@linutronix.de>, <james.morse@arm.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
Date: Mon, 14 Oct 2019 09:51:25 +0000	[thread overview]
Message-ID: <20191014095115.GA2203@localhost.localdomain> (raw)
In-Reply-To: <CAKv+Gu-aOHbdG2T9fPp7S4PvRAVosnsnCdsdHEk5PHnSN4gBrQ@mail.gmail.com>

On Mon, Oct 14, 2019 at 08:49:51AM +0200, Ard Biesheuvel wrote:
> 
> [EXTERNAL EMAIL] 
> 
> On Mon, 14 Oct 2019 at 08:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Narendra,
> >
> > On Sun, Oct 13, 2019 at 8:57 PM <Narendra.K@dell.com> wrote:
> > > From: Narendra K <Narendra.K@dell.com>
> > >
> > > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> > > for input on platforms where the option may not be applicable. This patch
> > > modifies the kconfig option to ask the user for input only when CONFIG_X86
> > > or CONFIG_COMPILE_TEST is set to y.
> > >
> > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Suggested-by: ...?
> >
> 
> Indeed

Hi Ard/Geert,

Thank you for correcting this. Should the patch be resubmitted with
the above change made ?

> 
> > > Signed-off-by: Narendra K <Narendra.K@dell.com>
> >
> > Thanks for your patch!
> >
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> 
> Thanks all. I'll get this queued as a fix.

Thank you for review comments.
-- 
With regards,
Narendra K

      reply	other threads:[~2019-10-14  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13 18:57 [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Narendra.K
2019-10-13 19:15 ` Narendra.K
2019-10-14  6:41 ` Geert Uytterhoeven
2019-10-14  6:49   ` Ard Biesheuvel
2019-10-14  9:51     ` Narendra.K [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014095115.GA2203@localhost.localdomain \
    --to=narendra.k@dell.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=james.morse@arm.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).