From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 522BCECE599 for ; Wed, 16 Oct 2019 07:12:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26837217D6 for ; Wed, 16 Oct 2019 07:12:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="jBjaAwnW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbfJPHMk (ORCPT ); Wed, 16 Oct 2019 03:12:40 -0400 Received: from mail.skyhub.de ([5.9.137.197]:34946 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfJPHMk (ORCPT ); Wed, 16 Oct 2019 03:12:40 -0400 Received: from zn.tnic (p200300EC2F093900E460E23B12F7A6AE.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:3900:e460:e23b:12f7:a6ae]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A47CF1EC0CA8; Wed, 16 Oct 2019 09:12:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1571209958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=hCMIEpQo2zZVtw+c7T27PQGWxK9R4yH4oLgjyYmdmEs=; b=jBjaAwnWbMtQO5KJkx8Ds4V597Vk3RcnpH9z7AXPZBtVtzOME4gu6KPFZ3LOB+4xl79+Lj 8kPodzuqb3NA7rSD0JFdUgz7ajO/9BH8XZe+Q1k900RYstacd4xK+1KOE2EULuWK9npP7U hYwBeygUc058xRGplSLnZm1PpMuZkH8= Date: Wed, 16 Oct 2019 09:12:30 +0200 From: Borislav Petkov To: Herbert Xu , "David S. Miller" Cc: Jiri Slaby , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Boris Ostrovsky , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Matt Fleming , Ard Biesheuvel , Juergen Gross , linux-crypto@vger.kernel.org, linux-pm@vger.kernel.org, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v9 24/28] x86_64/asm: Change all ENTRY+ENDPROC to SYM_FUNC_* Message-ID: <20191016071230.GD1138@zn.tnic> References: <20191011115108.12392-1-jslaby@suse.cz> <20191011115108.12392-25-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191011115108.12392-25-jslaby@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Hi, On Fri, Oct 11, 2019 at 01:51:04PM +0200, Jiri Slaby wrote: > These are all functions which are invoked from elsewhere, so annotate > them as global using the new SYM_FUNC_START. And their ENDPROC's by > SYM_FUNC_END. > > And make sure ENTRY/ENDPROC is not defined on X86_64, given these were > the last users. > > Signed-off-by: Jiri Slaby > Reviewed-by: Rafael J. Wysocki [hibernate] > Reviewed-by: Boris Ostrovsky [xen bits] > Cc: "H. Peter Anvin" > Cc: Borislav Petkov > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: x86@kernel.org > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Pavel Machek > Cc: Matt Fleming > Cc: Ard Biesheuvel > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: linux-crypto@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-efi@vger.kernel.org > Cc: xen-devel@lists.xenproject.org > --- > arch/x86/boot/compressed/efi_thunk_64.S | 4 +- > arch/x86/boot/compressed/head_64.S | 16 +++--- > arch/x86/boot/compressed/mem_encrypt.S | 8 +-- > arch/x86/crypto/aegis128-aesni-asm.S | 28 ++++----- > arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 12 ++-- > arch/x86/crypto/aesni-intel_asm.S | 60 ++++++++++---------- > arch/x86/crypto/aesni-intel_avx-x86_64.S | 32 +++++------ > arch/x86/crypto/blowfish-x86_64-asm_64.S | 16 +++--- > arch/x86/crypto/camellia-aesni-avx-asm_64.S | 24 ++++---- > arch/x86/crypto/camellia-aesni-avx2-asm_64.S | 24 ++++---- > arch/x86/crypto/camellia-x86_64-asm_64.S | 16 +++--- > arch/x86/crypto/cast5-avx-x86_64-asm_64.S | 16 +++--- > arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 24 ++++---- > arch/x86/crypto/chacha-avx2-x86_64.S | 12 ++-- > arch/x86/crypto/chacha-avx512vl-x86_64.S | 12 ++-- > arch/x86/crypto/chacha-ssse3-x86_64.S | 12 ++-- > arch/x86/crypto/crc32-pclmul_asm.S | 4 +- > arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 4 +- > arch/x86/crypto/crct10dif-pcl-asm_64.S | 4 +- > arch/x86/crypto/des3_ede-asm_64.S | 8 +-- > arch/x86/crypto/ghash-clmulni-intel_asm.S | 8 +-- > arch/x86/crypto/nh-avx2-x86_64.S | 4 +- > arch/x86/crypto/nh-sse2-x86_64.S | 4 +- > arch/x86/crypto/poly1305-avx2-x86_64.S | 4 +- > arch/x86/crypto/poly1305-sse2-x86_64.S | 8 +-- > arch/x86/crypto/serpent-avx-x86_64-asm_64.S | 24 ++++---- > arch/x86/crypto/serpent-avx2-asm_64.S | 24 ++++---- > arch/x86/crypto/serpent-sse2-x86_64-asm_64.S | 8 +-- > arch/x86/crypto/sha1_avx2_x86_64_asm.S | 4 +- > arch/x86/crypto/sha1_ni_asm.S | 4 +- > arch/x86/crypto/sha1_ssse3_asm.S | 4 +- > arch/x86/crypto/sha256-avx-asm.S | 4 +- > arch/x86/crypto/sha256-avx2-asm.S | 4 +- > arch/x86/crypto/sha256-ssse3-asm.S | 4 +- > arch/x86/crypto/sha256_ni_asm.S | 4 +- > arch/x86/crypto/sha512-avx-asm.S | 4 +- > arch/x86/crypto/sha512-avx2-asm.S | 4 +- > arch/x86/crypto/sha512-ssse3-asm.S | 4 +- > arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 24 ++++---- > arch/x86/crypto/twofish-x86_64-asm_64-3way.S | 8 +-- > arch/x86/crypto/twofish-x86_64-asm_64.S | 8 +-- I could use an ACK for the crypto bits... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette